Fix Avisynth C plugin loader #41
Conversation
|
I have been using C plugins perfectly well, so I am not sure what phenomenon this is supposed to fix. |
|
This pull request needs to be seriously amended, or closed. It does not actually fix anything, or rather, it simply inverts the problem it purports to fix. Because there was absolutely no description of the problem it was supposed to be fixing, I had to figure it out on my own. After experiencing a strange issue under Wine64 (since I still do not have a 64-bit Windows to test against), I realized what it was this pull request was likely attempting to fix. 64-bit C-plugins (or just the FFMS2 C-plugin, likely the one most commonly used, aside from AssRender or possibly yadif, neither of which I've tested against this commit, nor do I know if they can even be built as 64-bit) are rejected by 64-bit AviSynth+ as invalid plugins. What this commit does is allow the 64-bit C-plugin to load. However, it correspondingly breaks 32-bit C-plugins. What 32-bit C plugins need in terms of a leading underscore and function location on avisynth_c_plugin_init and what 64-bit needs are exactly opposite of each other, it seems. Perhaps it's not this complicated and there is a middle ground that can work for both (or something we need to add to the C API doc page to account for this weirdness if this is something that only plugin authors can do). But this pull request as it is is not the solution to this problem. |
|
Just as qyot27 described. Closing PR, better fix available from pinterf. |
Fix C plugin loading problem.