-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support io.js 1.0 #78
Conversation
Fix the condition used to check whether streams are modern, correctly detect io.js 1.0 as a modern engine.
FWIW, the test failure seems like a timing problem, tests sometimes fail sometimes pass when run on my machine. |
Workaround for phantomjs, until this patch is landed: install phantomjs globally, e.g. via |
Sorry, didn't see this until just now. Any insight on those across-the-board test failures from Travis? |
IIRC, the test "ncp modified files copies change source file mtime and copy" fails on some runs and then passes on subsequent runs. I assume it's a timing issue in the test, but I don't have time to investigate it myself. |
You can try to re-run the CI jobs, possibly repeatedly, and hopefully after few runs the tests will be green. |
pending AvianFlu/ncp#78
pending AvianFlu/ncp#78
pending AvianFlu/ncp#78
Necessary for ncp to work with iojs, which is necessary for generator-loopback tests to pass on iojs.
pending AvianFlu/ncp#78
* Upgrade ncp to ^2.0 to support io.js (Miroslav Bajtoš) * deps: use patched ncp pending AvianFlu/ncp#78 (Ryan Graham) * Fix bad CLA URL in CONTRIBUTING.md (Ryan Graham)
Fix the condition used to check whether streams are modern, correctly detect io.js 1.0 as a modern engine.
This fixes the install script used by phantomjs which hangs inside
ncp
at the moment.I was not able to reproduce the problem locally inside ncp, thus there is no test to cover this change :(
@mmalecki @AvianFlu Could you please review, land and release this patch as soon as reasonably possible?
ncp
is used e.g. by Karma test runner (karma-phantomjs-launcher), thus most front-end people cannot upgrade to io.js until this fix is landed.