Avian 4.1 release plan

[alamshafil]

This issue tracks the work that needs to be done to release Avian 4.1.
Nothing here is final and is subject to CHANGE!

Tentative deadlines

• Deadline for pull requests: 2022-09-23

MUST HAVE (delay without these having been merged)

• 5% block reward code to AVN foundation wallet #87
  • Set main-net address (multi-sig)
  • Clean up debug log FounderPayment::FillFounderPayment -- Founder payment 0
  • Fix testnet
• ans: Implement Avian Name System (AIP-4) #162
• qt: 4.1 UI fixup #164
• block: Cache PoW hashs #168
• chain: Use correct BIP44 cointype for mainnet (921) #170
• qt: Check wallet model to prevent segfault #172

COULD HAVE (non-critical for release)

• ci: Add and fix testing to workflow #72
• validation: Do not check PoW when downloading headers during IBD #157
• Corrected Grammatical errors #159
• Print CreateNewBlock() when BENCH debug is set #171

Maintainer tasks for release

• Update fixed seeds Update DNS seeders and fixed seeds #175
• Update checkpoints chain: Update assumed chain params #178
• Update copyrights
• Write release notes docs: Add release notes for 4.1 #176
• Mark v4.1 as release in source Mark 4.1 as release #179
• Tag v4.1
• Builds for v4.1
• Update master
• Upload binaries and sha256sum files

[alamshafil]

4.1 is ready for release, building binaries now.

[alamshafil]

4.1 has been released!

[crackfoo]

Why does getblocktemplate complain:

error -1: createnewblock: testblockvalidity failed: bad-cb-amount (code 16)

wallet debug says

2022-10-05 22:38:26 ERROR: ConnectBlock(): coinbase pays too much (actual=262500000000 vs limit=250000000000)
2022-10-05 22:38:26 ERROR: TestBlockValidity: Consensus::ConnectBlock: bad-cb-amount (code 16)

but I'm not even submitting a block... just asking for the template....

[alamshafil]

To properly assist you, make sure you running Avian 4.1 on commit 53947c4.

On my local node I was able to run the below without any issues:

• getblocktemplate
• getblocktemplate "{\"powalgo\": \"minotaurx\"}"
• getblocktemplate "{\"powalgo\": \"x16rt\"}"

Keep in mind that dev fee is already subtracted from coinbasevalue, ex: 237500000000.

From the value 262500000000, it looks like 5% of 2500 (125) was added to coinbase subsidy of 2500 (2625).

It is odd that your gbt is adding to coinbase. This is the code that checks coinbase: (AreEnforcedValuesDeployed() is always true)

Avian/src/validation.cpp

Lines 2805 to 2811 in 53947c4

	CAmount blockReward = nFees + GetBlockSubsidy(pindex->nHeight, chainparams.GetConsensus());
	if (block.vtx[0]->GetValueOut(AreEnforcedValuesDeployed()) > blockReward)
	return state.DoS(100,
	error("ConnectBlock(): coinbase pays too much (actual=%d vs limit=%d)",
	block.vtx[0]->GetValueOut(AreEnforcedValuesDeployed()), blockReward),
	REJECT_INVALID, "bad-cb-amount");

I know this is not related to getting a block template but make sure your pool is properly configured to support the dev fee. (Keep in mind that the founder address is a P2SH multi-sig addr and do not subtract from coinbase.)
Yiimp example: mivanoski/yiimp@9cff829

If you are still experiencing this problem, make a new issue with additional information (if possible). I apologize for the inconvenience.

[alamshafil]

To my understanding, getblocktemplate only performs TestBlockValidity() if the mode in the template request is set to proposal to check a block.