Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add middleware descriptor to pretty-middleware #29

Merged
merged 1 commit into from
Jan 9, 2015
Merged

Add middleware descriptor to pretty-middleware #29

merged 1 commit into from
Jan 9, 2015

Conversation

venantius
Copy link

This commit resolves issue #28. To review, at the moment opening a REPL
logs the following warning: "[WARNING] No nREPL middleware descriptor in
metadata of #'io.aviso.nrepl/pretty-middleware, see
clojure.tools.middleware/set-descriptor!"

In point of fact, they want you to look at
clojure.tools.nrepl.middleware/set-descriptor!

At any rate, this commit sets descriptor metadata on
io.aviso.nrepl/pretty-middleware so the error stops being thrown.

This commit resolves issue #28. To review, at the moment opening a REPL
logs the following warning: "[WARNING] No nREPL middleware descriptor in
metadata of #'io.aviso.nrepl/pretty-middleware, see
clojure.tools.middleware/set-descriptor!"

In point of fact, they want you to look at
`clojure.tools.nrepl.middleware/set-descriptor!`

At any rate, this commit sets descriptor metadata on
`io.aviso.nrepl/pretty-middleware` so the error stops being thrown.
hlship added a commit that referenced this pull request Jan 9, 2015
Add middleware descriptor to `pretty-middleware`
@hlship hlship merged commit 8744167 into clj-commons:master Jan 9, 2015
@hlship hlship self-assigned this Jan 9, 2015
@hlship hlship added this to the 0.1.14 milestone Jan 9, 2015
@venantius venantius deleted the fixing_middleware_descriptor branch January 9, 2015 20:49
@hlship hlship mentioned this pull request Jan 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants