Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding macOS Compatibility (via AppKit) #26

Open
martindufort opened this issue Dec 13, 2023 · 4 comments
Open

Adding macOS Compatibility (via AppKit) #26

martindufort opened this issue Dec 13, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@martindufort
Copy link
Contributor

I have forked this repo in order to add macOS compatibility and add it to one of our project.

In order to do so, without a huge amount of #if os(macOS) layered everywhere, I decided to leverage the compatibility framework UXKit: https://github.com/ZeeZide/UXKit

Are you interested in a PR that would support macOS compatibility or you intend on keeping this compatible with iOS macCatalyst only.

This will also imply that your package will have a dependency on UXKit to be compiled without errors.
Thanks

@martindufort martindufort added the enhancement New feature or request label Dec 13, 2023
@Awesomeplayer165
Copy link
Owner

I think it's fine to have that dependency as long as it builds on all platforms fine. Open!

@martindufort
Copy link
Contributor Author

martindufort commented Dec 13, 2023

Excellent. I can also submit a fix for issue #25 which I have resolved.
I'm also working on having the PillView always centered within the window to resolve issue #24

@martindufort
Copy link
Contributor Author

martindufort commented Dec 18, 2023

Little update on this PR.

I'm waiting for ZeeZide/UXKit#3 to be approved so I can submit my changes here (since there is now a dependency).

Not sure what the timeline is for the repo owner to action this.
Will let you know how it goes...

UPDATED
Decided to use the equivalent and simpler NSUI package to provide AppKit compatibility.

@Awesomeplayer165
Copy link
Owner

No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants