-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Await Logout till endSession is complete in logout #1298
Comments
Hi @pgangwani , Thank you for your issue. |
Thanks, I willl be waiting |
I forgot to tell you @pgangwani that version 7.18.3 should fix the bug :) |
I will give it a test |
@guillaume-chervet |
hi @pgangwani , does you oidc server support endSessionEndpoint ?
|
|
I need to understand what is the extra setting required at OIDC server level ? How is your example app using duende redirecitng to duende's logout with just mention of post_redirect_uri: '/profile' ? |
Hi @pgangwani , some extra are defined as oidc standards and some other are specific to some oidc provider. Do you still have some problem with logout? |
My problem was solved by my own hack of await logout();redirect(logoutUrl) but organically logging out like in your example. For which I raised this issue. |
Hi @pgangwani which browsers are you using? I think I am staring to understand to issue. |
Hi @guillaume-chervet, I am using Chrome v126.0.6478.116 Yes, I called the |
@suwarnoong @guillaume-chervet any help is required from me ? I still see this as an issue.
|
@pgangwani yes, it is still an issue for me as well on latest (v7.22.9). Could you share your own-hack for this? |
Does it work with version 7.22.13? |
Issue and Steps to Reproduce
In logout we have below steps
As 4 or 5 are exclusive steps , I am expecting async logout to await till all promises resolve including endSession.
I am thinking to get below case worked
Currently what is happening that if I am writing the window.location.href after await of logout, endSession request is cancelled. I need to redirect to logout to kill the session fully as per our oidc server. Attached below screenshot
Versions
7.18.1
Screenshots
Expected
Await(revoke(AT), revoke(RT), endSession(idToken)).then (() => custom redirect);
Actual
Await(revoke(AT), revoke(RT)).then (() => custom redirect);
and endSession(idToken) is cancelled
Additional Details
PLease let me know if I am missing something
The text was updated successfully, but these errors were encountered: