Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat generic mode for help component #188

Merged
merged 2 commits into from
May 1, 2019
Merged

Conversation

samuel-gomez-axa
Copy link
Contributor

Related issue

#187

On Mouse over on help component

Reference to the issue

#187

Description of the issue

On Mouse over on help component

Person(s) for reviewing proposed changes

@guillaumechervet

Important

Before creating a pull request run unit tests

$ npm test

# watch for changes
$ npm test -- --watch

# For a specific file (e.g., in packages/context/__tests__/command.test.js)
$ npm test -- --watch packages/action

@samuel-gomez-axa samuel-gomez-axa changed the title docs(changelog) update to new 1.2.1 Feat generic mode for help component Apr 29, 2019
@samuel-gomez-axa samuel-gomez-axa merged commit 3e298f6 into master May 1, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/help-component branch May 1, 2019 10:11
mergify bot pushed a commit that referenced this pull request May 2, 2019
* feat: home, getstarted, titlebar(wip)

* update style

* fix package all @import af-components

* feat(slider) add slider wrapped (#186)

* chore(release): publish v1.2.2 [ci skip]

* docs(changelog) update to new 1.2.2

*  fix(slider) fix value incorrect mapping (#190)

* fix(slider) fix value incorrect mapping
* fix(slider) incorrect value internal mapping

*  fix(slider) css width  (#192)

* chore(release): publish v1.2.3 [ci skip]

* docs(changelog) update to new 1.2.3

* fix(popover): not working with onclick mode (#194)

* chore(release): publish v1.2.4 [ci skip]

* docs(changelog) update to new 1.2.4

* Feat generic mode for help component (#188)

* feat: add mode props on Help Component
* feat: Change Help component to stateless (state delegate to Popover component)
* feat: Update Help and Popover stories for Storybook
* fix: sonar coverage help and popover component (~90%)

* feat: home, getstarted, titlebar(wip)

* update style

* fix package all @import af-components

* replace bad packages

* update design system toolkit package version

* add design build task azure pipeline

* fix: package informations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants