fix(popover): not working with onclick mode #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barry-thierno
previously approved these changes
Apr 30, 2019
vincent-ducrocq-axa
force-pushed
the
fix/popover-onclick-notopen
branch
from
be86193
to
4e308f8
Compare
guillaumechervetaxa
approved these changes
Apr 30, 2019
mergify bot
pushed a commit
that referenced
this pull request
May 2, 2019
* feat: home, getstarted, titlebar(wip) * update style * fix package all @import af-components * feat(slider) add slider wrapped (#186) * chore(release): publish v1.2.2 [ci skip] * docs(changelog) update to new 1.2.2 * fix(slider) fix value incorrect mapping (#190) * fix(slider) fix value incorrect mapping * fix(slider) incorrect value internal mapping * fix(slider) css width (#192) * chore(release): publish v1.2.3 [ci skip] * docs(changelog) update to new 1.2.3 * fix(popover): not working with onclick mode (#194) * chore(release): publish v1.2.4 [ci skip] * docs(changelog) update to new 1.2.4 * Feat generic mode for help component (#188) * feat: add mode props on Help Component * feat: Change Help component to stateless (state delegate to Popover component) * feat: Update Help and Popover stories for Storybook * fix: sonar coverage help and popover component (~90%) * feat: home, getstarted, titlebar(wip) * update style * fix package all @import af-components * replace bad packages * update design system toolkit package version * add design build task azure pipeline * fix: package informations
|
close #193 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#193
Description of the issue
Popover not working with onclick mode (nothing appens)
Person(s) for reviewing proposed changes
@guillaumechervet
@samuel-gomez-axa
@barry-thierno