Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimpleDeadlineManager does not use CorrelationDataProviders #2620

Closed
CodeDrivenMitch opened this issue Feb 24, 2023 · 1 comment
Closed

SimpleDeadlineManager does not use CorrelationDataProviders #2620

CodeDrivenMitch opened this issue Feb 24, 2023 · 1 comment
Assignees
@smcvb
Labels
Priority 3: Could Low priority. Issues that are nice to have but have a straightforward workaround. Status: Resolved Use to signal that work on this issue is done. Type: Bug Use to signal issues that describe a bug within the system.
Milestone
Release 4.7.2

Comments

@CodeDrivenMitch
Copy link
Member

CodeDrivenMitch commented Feb 24, 2023 •
edited

Basic information

  • Axon Framework version: 4.6.2
  • JDK version: 17
  • Complete executable reproducer if available (e.g. GitHub Repo): -

Steps to reproduce

  • Configure SimpleDeadlineManager
  • Handle command that publishes deadline

Expected behaviour

Deadline has metadata as provided by CorrelationDataProviders in the UnitOfWork

Actual behaviour

It doesn't. It's because it uses the asDeadlineManager that uses a constructor that doesn't delegate to the GenericMessage that sets the correlationdata from the UoW.
@CodeDrivenMitch CodeDrivenMitch added Type: Bug Use to signal issues that describe a bug within the system. Priority 3: Could Low priority. Issues that are nice to have but have a straightforward workaround. labels Feb 24, 2023
@smcvb smcvb added this to the Release 4.7.2 milestone Feb 24, 2023
@smcvb smcvb self-assigned this Feb 24, 2023
@smcvb smcvb added the Status: In Progress Use to signal this issue is actively worked on. label Feb 24, 2023
@smcvb smcvb mentioned this issue Feb 27, 2023
Merged
smcvb added a commit that referenced this issue Feb 28, 2023
@smcvb
Merge pull request #2624 from AxonFramework/bug/2620-deadline-manager…
d4b465b 
…-correlation-data

[#2620] Test correlation data population for `DeadlineManager` implementations
@smcvb
Copy link
Member

smcvb commented Feb 28, 2023

Closing this issue since it's resolved by #2624.

@smcvb smcvb closed this as completed Feb 28, 2023
@smcvb smcvb added Status: Resolved Use to signal that work on this issue is done. and removed Status: In Progress Use to signal this issue is actively worked on. labels Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smcvb smcvb

Labels
Priority 3: Could Low priority. Issues that are nice to have but have a straightforward workaround. Status: Resolved Use to signal that work on this issue is done. Type: Bug Use to signal issues that describe a bug within the system.
Projects
None yet
Milestone
Release 4.7.2
Development

No branches or pull requests
2 participants
@CodeDrivenMitch @smcvb