Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2620] Test correlation data population for DeadlineManager implementations #2624

Merged
merged 2 commits into from Feb 28, 2023
Merged

[#2620] Test correlation data population for DeadlineManager implementations #2624

merged 2 commits into from Feb 28, 2023

Conversation

smcvb
Copy link
Member

@smcvb smcvb commented Feb 27, 2023

This pull request adds a test to the AbstractDeadlineManagerTestSuite validating that correlation data is propagated when a deadline is scheduled.
to that end, a test is added for both Aggregate and Saga scheduling.

Through this, I've confirmed that a vanilla configuration of the SimpleDeadlineManager correctly retrieves correlation data.
This PR thus resolves #2620, describing this not to work for the SimpleDeadlineManager.

@smcvb
Add tests validating correlation data is populated for deadlines
92ab77a 
Add tests validating correlation data is populated for deadlines. Test
for both Aggregates and Saga.

#bug/2620
@smcvb
Merge branch 'axon-4.7.x' into bug/2620-deadline-manager-correlation-…
0a498ca 
…data
@smcvb smcvb added Type: Bug Use to signal issues that describe a bug within the system. Priority 3: Could Low priority. Issues that are nice to have but have a straightforward workaround. Status: In Progress Use to signal this issue is actively worked on. labels Feb 27, 2023
@smcvb smcvb added this to the Release 4.7.2 milestone Feb 27, 2023
@smcvb smcvb requested a review from a team February 27, 2023 13:43
@smcvb smcvb self-assigned this Feb 27, 2023
@smcvb smcvb requested review from gklijs and CodeDrivenMitch and removed request for a team February 27, 2023 13:43
gklijs
gklijs approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@gklijs gklijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I hope the merge to master will go well since the class is moved.

@smcvb
Copy link
Member Author

smcvb commented Feb 27, 2023

Looks good to me. I hope the merge to master will go well since the class is moved.

My thoughts exactly 😅
I'll be certain to keep an eye out for it, though.

@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@smcvb smcvb merged commit d4b465b into axon-4.7.x Feb 28, 2023
@smcvb smcvb deleted the bug/2620-deadline-manager-correlation-data branch February 28, 2023 14:10
@smcvb smcvb mentioned this pull request Feb 28, 2023
Closed
@smcvb smcvb added Status: Resolved Use to signal that work on this issue is done. and removed Status: In Progress Use to signal this issue is actively worked on. labels Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gklijs gklijs gklijs approved these changes

@CodeDrivenMitch CodeDrivenMitch Awaiting requested review from CodeDrivenMitch CodeDrivenMitch was automatically assigned from AxonFramework/framework-developers

Assignees

@smcvb smcvb

Labels
Priority 3: Could Low priority. Issues that are nice to have but have a straightforward workaround. Status: Resolved Use to signal that work on this issue is done. Type: Bug Use to signal issues that describe a bug within the system.
Projects
None yet
Milestone
Release 4.7.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smcvb @gklijs