[#1964] Include AxonServerHealthIndicator
#2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose the connection of the AxonServerConnectionManager through the ConnectionManager interface #1964
Introduce an AxonServer health indicator by implementing the AbstractHealthIndicator. It should add the connectivity of the existing contexts within the AxonServerConnectionManager through the Health .Builder #1964
Introduce an autoconfiguration class constructing an AxonServerHealthIndicator bean if actuator is present on the classpath #1964
Fix the broken spring boot tests by ignoring the new AxonServerActuatorAutoConfiguration either by excluding it or through the axonserver.enabled=false property #1964
Adjust the AxonServerHealthIndicator to share a status field as well. This status field should include the additional status "WARN" for when one of the contexts the app is connected with, is down. To support this thoroughly, a StatusAggregate should be included. #1964
smcvb
added
Type: Feature
smcvb
requested review from
gklijs,
sandjelkovic,
m1l4n54v1c,
MGathier and
saratry
- Add private constructor for the utility class HealthStatus - Check for nullability of the connectionStatus boxed boolean #1964
MGathier
approved these changes
Mar 10, 2022
|
Kudos, SonarCloud Quality Gate passed! |
gklijs
approved these changes
Mar 10, 2022
smcvb
added
Status: Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the
AxonServerHealthIndicator, adding theaxonServercomponent when investigating/actuator/health(with the right credentials).This Spring Boot Actuator
HealthIndicatorshares whether the contexts an Axon Framework application is connected with are active.It does so by requesting the available connections from the
AxonServerConnectionManager.When all connections are active, the
UPstatus is shared.When all connections are inactive, the
DOWNstatus is projected.When one of the connections is inactive, the custom
WARNstatus is shown.This approach is in line with what Axon Server's local health indicator shows.
Next to the status, details are provided about the separate connection's activity.
These can be found under
{context-name}.connection.active.This pull request resolves #1964