Multiteant support #2156
Merged
Multiteant support #2156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add patch updates to the main dependabot.yml. Apparently dependabot only checks for the base branch, where they're not planning to change this either - dependabot/dependabot-core#2159 Hence, let's add it to the main dependabot file
Ignore patch updates for the main branch, since those are taken care of by the patch branch.
Signed-off-by: Nils Christian Ehmke <nils@rhocas.de>
Add catch clause to log a dedicated warning for testing clarity #167
…ngboot/autoconfig/AxonServerBusAutoConfiguration.java Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
…ngboot/autoconfig/AxonServerBusAutoConfiguration.java Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
Closed
smcvb
added
Type: Feature
smcvb
reviewed
Mar 25, 2022
...re/src/main/java/org/axonframework/springboot/autoconfig/AxonServerBusAutoConfiguration.java
Show resolved
Hide resolved
smcvb
reviewed
Mar 25, 2022
| @@ -62,17 +62,27 @@ | |||
| } | |||
|
|
|||
| private <T> Property createProperty(String associationPropertyName, MessageHandlingMember<T> handler) { | |||
| if (associationPropertyName.isEmpty()) { | |||
There was a problem hiding this comment.
Still weird this is in here...although it doesn't hurt either.
smcvb
approved these changes
Mar 25, 2022
There was a problem hiding this comment.
If you change the bean neam of the AxonServerCommandBus to commandBus, than I'm a happy man.
Furthermore, the build is still failing, because of auto-config tests.
I'm trusting you'll fix those, though. To not waste more time, I'll thus approve this PR.
Be sure to fix the build before merging, though!
…ngboot/autoconfig/AxonServerBusAutoConfiguration.java Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
|
SonarCloud Quality Gate failed. |
smcvb
added
Status: Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes required for multiteant support (new PR to fix github action being stuck)