Display 'Validate document' menu item only when applicable #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are trying to avoid Officers from forgetting to click the “Confirm vote” button, which is necessary to keep track of who has voted a Poll To do that, we are not displaying the menu item to go back to the next person that wants to vote, until the Officer clicks the “Confirm Vote” button or the “The user has decided not to vote” button Note: Due to mobile version we have duplicate ids, so using classes for the menu items to hide them without errors Note2: We are only hidding the menu item, if there are votable polls, otherwise the “Confirm vote” button does not appear, and there is no way of going back to help the next person that wants to vote
voodoorai2000
force-pushed
the
budget_poll_menu
branch
from
947b83d
to
0402148
Compare
MariaCheca
approved these changes
Jun 21, 2018
decabeza
approved these changes
Jun 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Issue: consuldemocracy#2639
Background
We are trying to avoid Officers from forgetting to click the “Confirm vote” button, which is necessary to keep track of who has voted a Poll
Objectives
Visual Changes
Does this PR need a Backport to CONSUL?
Yes. Backported in consul#3343.
Notes
Due to mobile version we have duplicate ids for menu items, so using classes for the menu items to hide them correctly
Maybe a custom layout for this page, without menu items, and instead buttons for the next actions, would be more appropriate, we'll explore the idea 😌