Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] CRUD budgets and content blocks #1795

Merged
merged 2 commits into from
Jan 14, 2019
Merged

[Improvement] CRUD budgets and content blocks #1795

merged 2 commits into from
Jan 14, 2019

Conversation

microweb10
Copy link
Collaborator

@microweb10 microweb10 commented Jan 4, 2019 •
edited
Loading

Objectives

  • Improve messages of links to go back from budget groups and headings.
  • Highlight the budget section in the admin menu.
  • Improve explanation texts about content blocks.
  • Refactor code to make it more readable.

Visual Changes

BEFORE

1

AFTER

2

BEFORE

3

AFTER

4

BEFORE

5

AFTER

6

Does this PR need a Backport to CONSUL?

Yes

Notes

⚠️ From now on, content blocks are supposed to have only links. If you previously had some other HTML injected by using the content blocks feature, it might not render as it did before ☺️ . If you would like to make more specific changes to the footer or other views check out the docs on creating custom views https://consul_docs.gitbooks.io/docs/en/customization/views_and_styles.html

@microweb10 microweb10 self-assigned this Jan 4, 2019
@microweb10 microweb10 added this to Review in Roadmap Jan 4, 2019
@microweb10 microweb10 merged commit c72389d into master Jan 14, 2019
@microweb10 microweb10 deleted the improve_crud_budgets branch January 14, 2019 11:53
@microweb10 microweb10 moved this from Review to Done in Roadmap Jan 14, 2019
@microweb10 microweb10 mentioned this pull request Jan 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@voodoorai2000 voodoorai2000 voodoorai2000 approved these changes

@decabeza decabeza decabeza approved these changes

Assignees

@microweb10 microweb10

Labels
Backport Needed Improvement
Projects
Roadmap
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@microweb10 @voodoorai2000 @decabeza @houndci-bot