Update recent model and migration files #1975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
javierm
force-pushed
the
update_recent_migrations
branch
from
02b2244
to
2a69078
Compare
javierm
changed the title
javierm
changed the title
These migrations were created shortly before updating to Rails 5, and so they didn't have the version number.
This model was added after the Rails 5 branch was created but before it was merged.
javierm
force-pushed
the
update_recent_migrations
branch
from
2a69078
to
01d5559
Compare
It was accidentally added again when solving conflicts between `master` and the branches for Rails 5 and translations.
voodoorai2000
approved these changes
Apr 25, 2019
|
Travis build failed due to issue consul#3451, which is not related to this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Upgrade migration and model files in order to follow Rails 5 inheritance conventions. These migrations and models were created shortly before updating to Rails 5, and so the migrations didn't have the version number and the models inherited from
ActiveRecord::Baseinstead ofApplicationRecord.Does this PR need a Backport to CONSUL?
Yes, backport when backporting the pull requests which generated these migrations. The part related to
image_attributesis already backported in consul#3520, and the part related to stats migrations is already backported in consul#3512.