Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI improvement for hierarchy tree #834

Merged
merged 8 commits into from
Jun 16, 2022
Merged

UI improvement for hierarchy tree #834

merged 8 commits into from
Jun 16, 2022

Conversation

satche
Copy link
Contributor

@satche satche commented Jun 13, 2022

Description

Improve UI for the hierarchy tree. It includes responsivness, button styles, top node interactions and labels

Type of change

  • Bug fix
  • New feature
  • Refactoring / style
  • Documentation update / chore
  • Other (please describe)

Versioning

  • Version is updated
  • Changed files hash is updated

Satche added 4 commits June 13, 2022 11:32
Fix details on the bottom of the dialog
Make the tree view take the rest of the available space of the dialog
Distinguish between action buttons and remove origins tags-like button
@netlify
Copy link

netlify bot commented Jun 13, 2022

Deploy Preview for afmg ready!

Name Link
🔨 Latest commit 10564bf
🔍 Latest deploy log https://app.netlify.com/sites/afmg/deploys/62ab3aa1d5eaa200080649c3
😎 Deploy Preview https://deploy-preview-834--afmg.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Azgaar Azgaar self-requested a review June 13, 2022 11:20
@Azgaar
Copy link
Owner

Azgaar commented Jun 13, 2022

Thanks! I will take a look

@Azgaar
Copy link
Owner

Azgaar commented Jun 13, 2022

Looks good, can you please update the version and hash of changed files? We need this to force cache update on users' side

@satche
Copy link
Contributor Author

satche commented Jun 13, 2022

Done. I'm not sure which files require a hash update (since I just changed hierarchy-tree.js), but I did it on the ones that could make sense.

@Azgaar
Copy link
Owner

Azgaar commented Jun 13, 2022

Need to update hash for hierarchy-tree.js as it's the one that adds these styles. index.css is untouched. hierarchy-tree.js is loaded from the editors.js, hach for which has to be updated as well. Weird, we will automate it eventually.

@Azgaar Azgaar merged commit 8c96a97 into Azgaar:master Jun 16, 2022
@Azgaar
Copy link
Owner

Azgaar commented Jun 16, 2022

Merged, thanks for the contribution!

sofronaspe pushed a commit to sofronaspe/Fantasy-Map-Generator that referenced this pull request Nov 27, 2022
* style(hierarchy tree): improve responsivness

Fix details on the bottom of the dialog
Make the tree view take the rest of the available space of the dialog

* style(hierarchy tree): distinguish buttons

Distinguish between action buttons and remove origins tags-like button

* typo(hierarchy tree): change button label and tips

* fix(hierarchy tree): disable top node interactions

* chore: update version/hash to v1.86.07

* chore: update version/hash to v1.86.08

* fix: bad hash versions

* fix: update index.html to correct versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants