Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing the size of the culture center circle #855

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Reducing the size of the culture center circle #855

merged 2 commits into from
Aug 17, 2022

Conversation

schizoidnightmares
Copy link
Contributor

This makes it easier to place the center more precisely and to see what cell it is in.

Description

The culture centers are currently displayed far too prominently. For culture centers placed closed together, it makes it near impossible to view them properly. Even for culture centers placed far apart, due to the size of the circle, it makes it difficult to figure out what cell the center is actually in.

While decreasing the visual size of the culture centers in this manner is not ideal (ideally there should be an option to adjust their size in the future), it is better than the present.

Type of change

  • Bug fix
  • New feature
  • Refactoring / style
  • Documentation update / chore
  • Other (please describe)

Versioning

  • Version is updated
  • Changed files hash is updated

This makes it easier to place the center more precisely and to see what cell it is in.
@netlify
Copy link

netlify bot commented Aug 13, 2022

Deploy Preview for afmg ready!

Name Link
🔨 Latest commit 45afa52
🔍 Latest deploy log https://app.netlify.com/sites/afmg/deploys/62fc11fdcb24a30008a11924
😎 Deploy Preview https://deploy-preview-855--afmg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Azgaar Azgaar self-requested a review August 14, 2022 16:07
@Azgaar
Copy link
Owner

Azgaar commented Aug 14, 2022

Culture centers are too small now, almost invisible on a default zoom level. Can they be somewhere in between? Also can set their size dynamically based on a zoom level

@schizoidnightmares
Copy link
Contributor Author

Culture centers are too small now, almost invisible on a default zoom level. Can they be somewhere in between? Also can set their size dynamically based on a zoom level

I went for the smallest size to accommodate smaller sized cells on larger cell count maps. It is not ideal but better since you can still zoom in on them. I do agree a dynamic model would be better. I am not sure how to do that though. What is something that the FMG already dynamically resizes based on zoom? If I look at something like that, maybe that will point me in the right direction.

@Azgaar
Copy link
Owner

Azgaar commented Aug 15, 2022

Labels are getting auto-zoomed. As for now we can just stay on a middle ground

@schizoidnightmares
Copy link
Contributor Author

Labels are getting auto-zoomed. As for now we can just stay on a middle ground

I increased the size of the cultural centers. Do they look acceptable now? I tried also going slightly bigger than this change but any bigger and they overlap too much if placed beside each other.

@Azgaar
Copy link
Owner

Azgaar commented Aug 17, 2022

It looks better now

@Azgaar Azgaar marked this pull request as ready for review August 17, 2022 07:15
@Azgaar Azgaar merged commit bfba711 into Azgaar:master Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants