Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marker Generator Changes #872

Merged
merged 6 commits into from
Sep 21, 2022
Merged

Marker Generator Changes #872

merged 6 commits into from
Sep 21, 2022

Conversation

sofronaspe
Copy link
Contributor

Description

I'm interested in contributing to a project that I've spent a lot of time using, so I decided to make this first PR a simple new feature by changing the following markers:

  • Volcanos will say dormant, active, or erupting in their legend
  • Sacred Pineries, Sacred Mountains, and Sacred Groves only spawn in religious cells
  • Sacred Pineries, Sacred Mountains, and Sacred Groves reference their cell religion in their legend
  • New Cave marker which spawns near mountains

Type of change

  • Bug fix
  • New feature
  • Refactoring / style
  • Documentation update / chore
  • Other (please describe)

Versioning

  • Version is updated
  • Changed files hash is updated

@netlify
Copy link

netlify bot commented Sep 20, 2022

Deploy Preview for afmg ready!

Name Link
🔨 Latest commit 87d1259
🔍 Latest deploy log https://app.netlify.com/sites/afmg/deploys/632b809863c70a00091e41b7
😎 Deploy Preview https://deploy-preview-872--afmg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

modules/markers-generator.js Outdated Show resolved Hide resolved
modules/markers-generator.js Outdated Show resolved Hide resolved
modules/markers-generator.js Outdated Show resolved Hide resolved
modules/markers-generator.js Outdated Show resolved Hide resolved
@Azgaar
Copy link
Owner

Azgaar commented Sep 21, 2022

Hello and thanks for the contribution! It looks good, I just made a couple of mainly stylistic comments.

@Azgaar
Copy link
Owner

Azgaar commented Sep 21, 2022

Looks good, releasing!

@Azgaar Azgaar merged commit 0653e66 into Azgaar:master Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants