Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bb): op counting mode #4437

Merged
merged 14 commits into from
Feb 6, 2024
Merged

feat(bb): op counting mode #4437

merged 14 commits into from
Feb 6, 2024

Conversation

ludamad
Copy link
Collaborator

@ludamad ludamad commented Feb 5, 2024

  • Introduces preset 'op-counting' that builds with support for operation counts
  • Introduces mechanism to connect this to google benchmark
  • Support for ultra_honk_rounds_bench and goblin_bench right now
    image

For best results run with e.g. ./bin/goblin_bench --benchmark_min_time=0s --benchmark_counters_tabular=true

other: - Make macros consistently have BB_, rename some BBERG_ macros

@ludamad ludamad marked this pull request as ready for review February 5, 2024 23:24
@AztecBot
Copy link
Collaborator

AztecBot commented Feb 5, 2024

Benchmark results

Metrics with a significant change:

  • note_trial_decrypting_time_in_ms (8): 18.6 (-83%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit a6179bdb and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,636 180,516 720,036
l1_rollup_calldata_gas 222,444 871,068 3,465,924
l1_rollup_execution_gas 314,931 988,808 3,685,581
l2_block_processing_time_in_ms 1,175 (+2%) 4,671 (+7%) 17,398 (+1%)
note_successful_decrypting_time_in_ms 309 (+3%) 1,020 (+6%) 3,756 (+4%)
note_trial_decrypting_time_in_ms ⚠️ 18.6 (-83%) 49.1 (-50%) 162 (+12%)
l2_block_building_time_in_ms 18,017 70,810 284,720
l2_block_rollup_simulation_time_in_ms 13,259 (+1%) 52,004 (+1%) 209,301 (+1%)
l2_block_public_tx_process_time_in_ms 4,730 (-3%) 18,726 (-1%) 75,149 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 13,715 (-1%) 26,278
note_history_successful_decrypting_time_in_ms 2,293 (-3%) 4,530 (-2%)
note_history_trial_decrypting_time_in_ms 175 (+73%) 216 (-1%)
node_database_size_in_bytes 17,342,544 33,013,840
pxe_database_size_in_bytes 29,923 59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 309 44,480 26,193
private-kernel-ordering 192 (-4%) 44,513 14,929 (-10%)
base-rollup 1,409 128,970 881
root-rollup 82.0 (-1%) 4,088 677
private-kernel-inner 434 (-3%) 71,639 26,193
public-kernel-private-input 240 (-3%) 32,615 26,193
public-kernel-non-first-iteration 239 (-3%) 32,657 26,193
merge-rollup 7.62 2,608 881

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 2 leaves 8 leaves 16 leaves 32 leaves 128 leaves 64 leaves 512 leaves 1024 leaves 2048 leaves 8192 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.2 11.6 (+8%) 12.8 (+2%) 17.0 (+2%) 27.9 (+22%) 64.7 (+1%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.9 17.5 23.0 31.6 47.0 143 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.594 0.649 (+7%) 0.544 (+1%) 0.523 (+1%) 0.585 (+22%) 0.444 (+1%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A N/A N/A N/A 80.9 (+9%) 47.5 241 (+1%) 460 901 3,581 (+1%)
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A N/A N/A N/A 159 96.0 543 1,055 2,079 8,223
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A N/A N/A N/A 0.499 (+9%) 0.488 (-1%) 0.439 (+1%) 0.431 0.428 0.430 (+1%)
batch_insert_into_indexed_tree_20_depth_ms N/A N/A N/A N/A N/A 105 (+1%) 56.7 358 (+3%) 685 (-1%) 1,365 5,434 (+1%)
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A N/A N/A N/A 197 104 691 1,363 2,707 10,771
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A N/A N/A N/A 0.501 (+2%) 0.497 0.485 (+2%) 0.472 0.474 0.471
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A 56.5 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A 94.1 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A 0.578 N/A N/A N/A N/A N/A N/A N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 15,575 (-10%) 38,325 (-4%)

Transaction processing duration by data writes.

Metric 0 new commitments 1 new commitments
tx_pxe_processing_time_ms 557 1,303 (-2%)
Metric 0 public data writes 1 public data writes
tx_sequencer_processing_time_ms 0.518 (+2%) 578 (-2%)

Copy link
Contributor

@codygunton codygunton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sick

@codygunton codygunton merged commit 5d00cff into master Feb 6, 2024
88 checks passed
@codygunton codygunton deleted the feat/bb/op_counts branch February 6, 2024 20:59
@ludamad ludamad mentioned this pull request Feb 6, 2024
rahul-kothari pushed a commit that referenced this pull request Feb 7, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.23.0</summary>

##
[0.23.0](aztec-packages-v0.22.0...aztec-packages-v0.23.0)
(2024-02-07)


### ⚠ BREAKING CHANGES

* rename bigint_neg into bigint_sub
(#4420)
* Add expression width into acir
(#4014)
* init storage macro
(#4200)
* **acir:** Move `is_recursive` flag to be part of the circuit
definition (#4221)
[skip ci]

### Features

* Add additional error types to verifier contract and revert early
([#4464](#4464))
([5e16063](5e16063))
* Add bit size to const opcode
(#4385)
([4113cfd](4113cfd))
* Add expression width into acir
(#4014)
([4113cfd](4113cfd))
* Allow brillig to read arrays directly from memory
(#4460)
([4113cfd](4113cfd))
* Allow nested arrays and vectors in Brillig foreign calls
([#4478](#4478))
([bbfa337](bbfa337))
* Allow nested arrays and vectors in Brillig foreign calls
(#4478)
([4113cfd](4113cfd))
* **avm:** Back in avm context with macro - refactor context
(#4438)
([4113cfd](4113cfd))
* **avm:** Generic bytecode deserialization
([#4441](#4441))
([934fabc](934fabc)),
closes
[#4304](#4304)
* **avm:** Support variable size SET opcode
([#4465](#4465))
([545b334](545b334))
* **aztec-nr:** Initial work for aztec public vm macro
(#4400)
([4113cfd](4113cfd))
* **bb:** Op counting mode
([#4437](#4437))
([5d00cff](5d00cff))
* Canonical instance deployer contract
([#4436](#4436))
([b4acc8c](b4acc8c))
* Init storage macro
(#4200)
([4113cfd](4113cfd))
* Updating global vars with fees
([#4421](#4421))
([34109eb](34109eb)),
closes
[#3824](#3824)


### Bug Fixes

* Delay rming bins till right before installing them.
([#4474](#4474))
([fabeac8](fabeac8))
* **docs:** Add redirect for top google hit giving 404
([#4487](#4487))
([e1d3f5a](e1d3f5a))
* **docs:** Update mdx files to md
([#4459](#4459))
([e67d94b](e67d94b))
* **docs:** Update private voting tutorial cli commands
([#4472](#4472))
([0a8905a](0a8905a))
* Parse instance deployed event
([#4482](#4482))
([62b171a](62b171a))


### Miscellaneous

* Able to run noir-sync manually
([#4486](#4486))
([2082fed](2082fed))
* **acir:** Move `is_recursive` flag to be part of the circuit
definition (#4221)
[skip ci]
([4113cfd](4113cfd))
* Add bigint solver in ACVM and add a unit test for bigints in Noir
(#4415)
([4113cfd](4113cfd))
* Lift rollup address check & deplot kv-store to npm
([#4483](#4483))
([92d0aa4](92d0aa4))
* Nuked `OptionallyRevealedData`
([#4456](#4456))
([83a3136](83a3136))
* Rename bigint_neg into bigint_sub
(#4420)
([4113cfd](4113cfd))
* Replace relative paths to noir-protocol-circuits
([902bbd4](902bbd4))
* Surpress chained macro warning
(#4396)
([4113cfd](4113cfd))
* Sync to noir-lang/noir
([4113cfd](4113cfd))
* Unhardcode canonical addresses of deployer and registerer contracts
([#4467](#4467))
([2c82b62](2c82b62))
</details>

<details><summary>barretenberg.js: 0.23.0</summary>

##
[0.23.0](barretenberg.js-v0.22.0...barretenberg.js-v0.23.0)
(2024-02-07)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg: 0.23.0</summary>

##
[0.23.0](barretenberg-v0.22.0...barretenberg-v0.23.0)
(2024-02-07)


### Features

* Add additional error types to verifier contract and revert early
([#4464](#4464))
([5e16063](5e16063))
* Allow nested arrays and vectors in Brillig foreign calls
([#4478](#4478))
([bbfa337](bbfa337))
* **avm:** Generic bytecode deserialization
([#4441](#4441))
([934fabc](934fabc)),
closes
[#4304](#4304)
* **bb:** Op counting mode
([#4437](#4437))
([5d00cff](5d00cff))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
TomAFrench pushed a commit that referenced this pull request Feb 7, 2024
- Introduces preset 'op-counting' that builds with support for operation
counts
- Introduces mechanism to connect this to google benchmark
- Support for ultra_honk_rounds_bench and goblin_bench right now

![image](https://github.com/AztecProtocol/aztec-packages/assets/163993/9785e99b-ef1f-4ea6-bfab-cd63d33499e1)

For best results run with e.g. `./bin/goblin_bench
--benchmark_min_time=0s --benchmark_counters_tabular=true`

other: - Make macros consistently have BB_, rename some BBERG_ macros

---------

Co-authored-by: ludamad <adam@aztecprotocol.com>
TomAFrench pushed a commit that referenced this pull request Feb 7, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.23.0</summary>

##
[0.23.0](aztec-packages-v0.22.0...aztec-packages-v0.23.0)
(2024-02-07)


### ⚠ BREAKING CHANGES

* rename bigint_neg into bigint_sub
(#4420)
* Add expression width into acir
(#4014)
* init storage macro
(#4200)
* **acir:** Move `is_recursive` flag to be part of the circuit
definition (#4221)
[skip ci]

### Features

* Add additional error types to verifier contract and revert early
([#4464](#4464))
([5e16063](5e16063))
* Add bit size to const opcode
(#4385)
([4113cfd](4113cfd))
* Add expression width into acir
(#4014)
([4113cfd](4113cfd))
* Allow brillig to read arrays directly from memory
(#4460)
([4113cfd](4113cfd))
* Allow nested arrays and vectors in Brillig foreign calls
([#4478](#4478))
([bbfa337](bbfa337))
* Allow nested arrays and vectors in Brillig foreign calls
(#4478)
([4113cfd](4113cfd))
* **avm:** Back in avm context with macro - refactor context
(#4438)
([4113cfd](4113cfd))
* **avm:** Generic bytecode deserialization
([#4441](#4441))
([934fabc](934fabc)),
closes
[#4304](#4304)
* **avm:** Support variable size SET opcode
([#4465](#4465))
([545b334](545b334))
* **aztec-nr:** Initial work for aztec public vm macro
(#4400)
([4113cfd](4113cfd))
* **bb:** Op counting mode
([#4437](#4437))
([5d00cff](5d00cff))
* Canonical instance deployer contract
([#4436](#4436))
([b4acc8c](b4acc8c))
* Init storage macro
(#4200)
([4113cfd](4113cfd))
* Updating global vars with fees
([#4421](#4421))
([34109eb](34109eb)),
closes
[#3824](#3824)


### Bug Fixes

* Delay rming bins till right before installing them.
([#4474](#4474))
([fabeac8](fabeac8))
* **docs:** Add redirect for top google hit giving 404
([#4487](#4487))
([e1d3f5a](e1d3f5a))
* **docs:** Update mdx files to md
([#4459](#4459))
([e67d94b](e67d94b))
* **docs:** Update private voting tutorial cli commands
([#4472](#4472))
([0a8905a](0a8905a))
* Parse instance deployed event
([#4482](#4482))
([62b171a](62b171a))


### Miscellaneous

* Able to run noir-sync manually
([#4486](#4486))
([2082fed](2082fed))
* **acir:** Move `is_recursive` flag to be part of the circuit
definition (#4221)
[skip ci]
([4113cfd](4113cfd))
* Add bigint solver in ACVM and add a unit test for bigints in Noir
(#4415)
([4113cfd](4113cfd))
* Lift rollup address check & deplot kv-store to npm
([#4483](#4483))
([92d0aa4](92d0aa4))
* Nuked `OptionallyRevealedData`
([#4456](#4456))
([83a3136](83a3136))
* Rename bigint_neg into bigint_sub
(#4420)
([4113cfd](4113cfd))
* Replace relative paths to noir-protocol-circuits
([902bbd4](902bbd4))
* Surpress chained macro warning
(#4396)
([4113cfd](4113cfd))
* Sync to noir-lang/noir
([4113cfd](4113cfd))
* Unhardcode canonical addresses of deployer and registerer contracts
([#4467](#4467))
([2c82b62](2c82b62))
</details>

<details><summary>barretenberg.js: 0.23.0</summary>

##
[0.23.0](barretenberg.js-v0.22.0...barretenberg.js-v0.23.0)
(2024-02-07)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg: 0.23.0</summary>

##
[0.23.0](barretenberg-v0.22.0...barretenberg-v0.23.0)
(2024-02-07)


### Features

* Add additional error types to verifier contract and revert early
([#4464](#4464))
([5e16063](5e16063))
* Allow nested arrays and vectors in Brillig foreign calls
([#4478](#4478))
([bbfa337](bbfa337))
* **avm:** Generic bytecode deserialization
([#4441](#4441))
([934fabc](934fabc)),
closes
[#4304](#4304)
* **bb:** Op counting mode
([#4437](#4437))
([5d00cff](5d00cff))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Feb 8, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.23.0</summary>

##
[0.23.0](AztecProtocol/aztec-packages@aztec-packages-v0.22.0...aztec-packages-v0.23.0)
(2024-02-07)


### ⚠ BREAKING CHANGES

* rename bigint_neg into bigint_sub
(AztecProtocol/aztec-packages#4420)
* Add expression width into acir
(AztecProtocol/aztec-packages#4014)
* init storage macro
(AztecProtocol/aztec-packages#4200)
* **acir:** Move `is_recursive` flag to be part of the circuit
definition (AztecProtocol/aztec-packages#4221)
[skip ci]

### Features

* Add additional error types to verifier contract and revert early
([#4464](AztecProtocol/aztec-packages#4464))
([5e16063](AztecProtocol/aztec-packages@5e16063))
* Add bit size to const opcode
(AztecProtocol/aztec-packages#4385)
([4113cfd](AztecProtocol/aztec-packages@4113cfd))
* Add expression width into acir
(AztecProtocol/aztec-packages#4014)
([4113cfd](AztecProtocol/aztec-packages@4113cfd))
* Allow brillig to read arrays directly from memory
(AztecProtocol/aztec-packages#4460)
([4113cfd](AztecProtocol/aztec-packages@4113cfd))
* Allow nested arrays and vectors in Brillig foreign calls
([#4478](AztecProtocol/aztec-packages#4478))
([bbfa337](AztecProtocol/aztec-packages@bbfa337))
* Allow nested arrays and vectors in Brillig foreign calls
(AztecProtocol/aztec-packages#4478)
([4113cfd](AztecProtocol/aztec-packages@4113cfd))
* **avm:** Back in avm context with macro - refactor context
(AztecProtocol/aztec-packages#4438)
([4113cfd](AztecProtocol/aztec-packages@4113cfd))
* **avm:** Generic bytecode deserialization
([#4441](AztecProtocol/aztec-packages#4441))
([934fabc](AztecProtocol/aztec-packages@934fabc)),
closes
[#4304](AztecProtocol/aztec-packages#4304)
* **avm:** Support variable size SET opcode
([#4465](AztecProtocol/aztec-packages#4465))
([545b334](AztecProtocol/aztec-packages@545b334))
* **aztec-nr:** Initial work for aztec public vm macro
(AztecProtocol/aztec-packages#4400)
([4113cfd](AztecProtocol/aztec-packages@4113cfd))
* **bb:** Op counting mode
([#4437](AztecProtocol/aztec-packages#4437))
([5d00cff](AztecProtocol/aztec-packages@5d00cff))
* Canonical instance deployer contract
([#4436](AztecProtocol/aztec-packages#4436))
([b4acc8c](AztecProtocol/aztec-packages@b4acc8c))
* Init storage macro
(AztecProtocol/aztec-packages#4200)
([4113cfd](AztecProtocol/aztec-packages@4113cfd))
* Updating global vars with fees
([#4421](AztecProtocol/aztec-packages#4421))
([34109eb](AztecProtocol/aztec-packages@34109eb)),
closes
[#3824](AztecProtocol/aztec-packages#3824)


### Bug Fixes

* Delay rming bins till right before installing them.
([#4474](AztecProtocol/aztec-packages#4474))
([fabeac8](AztecProtocol/aztec-packages@fabeac8))
* **docs:** Add redirect for top google hit giving 404
([#4487](AztecProtocol/aztec-packages#4487))
([e1d3f5a](AztecProtocol/aztec-packages@e1d3f5a))
* **docs:** Update mdx files to md
([#4459](AztecProtocol/aztec-packages#4459))
([e67d94b](AztecProtocol/aztec-packages@e67d94b))
* **docs:** Update private voting tutorial cli commands
([#4472](AztecProtocol/aztec-packages#4472))
([0a8905a](AztecProtocol/aztec-packages@0a8905a))
* Parse instance deployed event
([#4482](AztecProtocol/aztec-packages#4482))
([62b171a](AztecProtocol/aztec-packages@62b171a))


### Miscellaneous

* Able to run noir-sync manually
([#4486](AztecProtocol/aztec-packages#4486))
([2082fed](AztecProtocol/aztec-packages@2082fed))
* **acir:** Move `is_recursive` flag to be part of the circuit
definition (AztecProtocol/aztec-packages#4221)
[skip ci]
([4113cfd](AztecProtocol/aztec-packages@4113cfd))
* Add bigint solver in ACVM and add a unit test for bigints in Noir
(AztecProtocol/aztec-packages#4415)
([4113cfd](AztecProtocol/aztec-packages@4113cfd))
* Lift rollup address check & deplot kv-store to npm
([#4483](AztecProtocol/aztec-packages#4483))
([92d0aa4](AztecProtocol/aztec-packages@92d0aa4))
* Nuked `OptionallyRevealedData`
([#4456](AztecProtocol/aztec-packages#4456))
([83a3136](AztecProtocol/aztec-packages@83a3136))
* Rename bigint_neg into bigint_sub
(AztecProtocol/aztec-packages#4420)
([4113cfd](AztecProtocol/aztec-packages@4113cfd))
* Replace relative paths to noir-protocol-circuits
([902bbd4](AztecProtocol/aztec-packages@902bbd4))
* Surpress chained macro warning
(AztecProtocol/aztec-packages#4396)
([4113cfd](AztecProtocol/aztec-packages@4113cfd))
* Sync to noir-lang/noir
([4113cfd](AztecProtocol/aztec-packages@4113cfd))
* Unhardcode canonical addresses of deployer and registerer contracts
([#4467](AztecProtocol/aztec-packages#4467))
([2c82b62](AztecProtocol/aztec-packages@2c82b62))
</details>

<details><summary>barretenberg.js: 0.23.0</summary>

##
[0.23.0](AztecProtocol/aztec-packages@barretenberg.js-v0.22.0...barretenberg.js-v0.23.0)
(2024-02-07)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg: 0.23.0</summary>

##
[0.23.0](AztecProtocol/aztec-packages@barretenberg-v0.22.0...barretenberg-v0.23.0)
(2024-02-07)


### Features

* Add additional error types to verifier contract and revert early
([#4464](AztecProtocol/aztec-packages#4464))
([5e16063](AztecProtocol/aztec-packages@5e16063))
* Allow nested arrays and vectors in Brillig foreign calls
([#4478](AztecProtocol/aztec-packages#4478))
([bbfa337](AztecProtocol/aztec-packages@bbfa337))
* **avm:** Generic bytecode deserialization
([#4441](AztecProtocol/aztec-packages#4441))
([934fabc](AztecProtocol/aztec-packages@934fabc)),
closes
[#4304](AztecProtocol/aztec-packages#4304)
* **bb:** Op counting mode
([#4437](AztecProtocol/aztec-packages#4437))
([5d00cff](AztecProtocol/aztec-packages@5d00cff))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
ludamad added a commit that referenced this pull request Feb 12, 2024
This expands on the previous
#4437 PR with the
ability to automatically microbenchmark pieces.

- If you want to measure timing , uses the preset `op-count-time`
- If you want to measure call counts, uses the preset `op-count-track`

Example of google benchmark running with preset op-count-time
```
------------------------------------------------------------------------------------
Benchmark                          Time             CPU   Iterations UserCounters...
------------------------------------------------------------------------------------
GoblinBench/GoblinFull/1       10609 ms         9065 ms            1 batch_mul_with_endomorphism=48 batch_mul_with_endomorphism(t)=646.575M
^C

-----------------------------------------------------------------------------------
Benchmark                         Time             CPU   Iterations UserCounters...
-----------------------------------------------------------------------------------
GoblinBench/GoblinFull/2      15225 ms        13342 ms            1 batch_mul_with_endomorphism=52 batch_mul_with_endomorphism(t)=1.02146G
```
Note with nanosecond units, one M(illion) is one millisecond, one G(iga)
is one second

---------

Co-authored-by: ludamad <adam@aztecprotocol.com>
AztecBot pushed a commit to AztecProtocol/barretenberg that referenced this pull request Feb 13, 2024
This expands on the previous
AztecProtocol/aztec-packages#4437 PR with the
ability to automatically microbenchmark pieces.

- If you want to measure timing , uses the preset `op-count-time`
- If you want to measure call counts, uses the preset `op-count-track`

Example of google benchmark running with preset op-count-time
```
------------------------------------------------------------------------------------
Benchmark                          Time             CPU   Iterations UserCounters...
------------------------------------------------------------------------------------
GoblinBench/GoblinFull/1       10609 ms         9065 ms            1 batch_mul_with_endomorphism=48 batch_mul_with_endomorphism(t)=646.575M
^C

-----------------------------------------------------------------------------------
Benchmark                         Time             CPU   Iterations UserCounters...
-----------------------------------------------------------------------------------
GoblinBench/GoblinFull/2      15225 ms        13342 ms            1 batch_mul_with_endomorphism=52 batch_mul_with_endomorphism(t)=1.02146G
```
Note with nanosecond units, one M(illion) is one millisecond, one G(iga)
is one second

---------

Co-authored-by: ludamad <adam@aztecprotocol.com>
michaelelliot pushed a commit to Swoir/noir_rs that referenced this pull request Feb 28, 2024
- Introduces preset 'op-counting' that builds with support for operation
counts
- Introduces mechanism to connect this to google benchmark
- Support for ultra_honk_rounds_bench and goblin_bench right now

![image](https://github.com/AztecProtocol/aztec-packages/assets/163993/9785e99b-ef1f-4ea6-bfab-cd63d33499e1)

For best results run with e.g. `./bin/goblin_bench
--benchmark_min_time=0s --benchmark_counters_tabular=true`

other: - Make macros consistently have BB_, rename some BBERG_ macros

---------

Co-authored-by: ludamad <adam@aztecprotocol.com>
michaelelliot pushed a commit to Swoir/noir_rs that referenced this pull request Feb 28, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.23.0</summary>

##
[0.23.0](AztecProtocol/aztec-packages@aztec-packages-v0.22.0...aztec-packages-v0.23.0)
(2024-02-07)


### ⚠ BREAKING CHANGES

* rename bigint_neg into bigint_sub
(AztecProtocol#4420)
* Add expression width into acir
(AztecProtocol#4014)
* init storage macro
(AztecProtocol#4200)
* **acir:** Move `is_recursive` flag to be part of the circuit
definition (AztecProtocol#4221)
[skip ci]

### Features

* Add additional error types to verifier contract and revert early
([AztecProtocol#4464](AztecProtocol#4464))
([5e16063](AztecProtocol@5e16063))
* Add bit size to const opcode
(AztecProtocol#4385)
([4113cfd](AztecProtocol@4113cfd))
* Add expression width into acir
(AztecProtocol#4014)
([4113cfd](AztecProtocol@4113cfd))
* Allow brillig to read arrays directly from memory
(AztecProtocol#4460)
([4113cfd](AztecProtocol@4113cfd))
* Allow nested arrays and vectors in Brillig foreign calls
([AztecProtocol#4478](AztecProtocol#4478))
([bbfa337](AztecProtocol@bbfa337))
* Allow nested arrays and vectors in Brillig foreign calls
(AztecProtocol#4478)
([4113cfd](AztecProtocol@4113cfd))
* **avm:** Back in avm context with macro - refactor context
(AztecProtocol#4438)
([4113cfd](AztecProtocol@4113cfd))
* **avm:** Generic bytecode deserialization
([AztecProtocol#4441](AztecProtocol#4441))
([934fabc](AztecProtocol@934fabc)),
closes
[AztecProtocol#4304](AztecProtocol#4304)
* **avm:** Support variable size SET opcode
([AztecProtocol#4465](AztecProtocol#4465))
([545b334](AztecProtocol@545b334))
* **aztec-nr:** Initial work for aztec public vm macro
(AztecProtocol#4400)
([4113cfd](AztecProtocol@4113cfd))
* **bb:** Op counting mode
([AztecProtocol#4437](AztecProtocol#4437))
([5d00cff](AztecProtocol@5d00cff))
* Canonical instance deployer contract
([AztecProtocol#4436](AztecProtocol#4436))
([b4acc8c](AztecProtocol@b4acc8c))
* Init storage macro
(AztecProtocol#4200)
([4113cfd](AztecProtocol@4113cfd))
* Updating global vars with fees
([AztecProtocol#4421](AztecProtocol#4421))
([34109eb](AztecProtocol@34109eb)),
closes
[AztecProtocol#3824](AztecProtocol#3824)


### Bug Fixes

* Delay rming bins till right before installing them.
([AztecProtocol#4474](AztecProtocol#4474))
([fabeac8](AztecProtocol@fabeac8))
* **docs:** Add redirect for top google hit giving 404
([AztecProtocol#4487](AztecProtocol#4487))
([e1d3f5a](AztecProtocol@e1d3f5a))
* **docs:** Update mdx files to md
([AztecProtocol#4459](AztecProtocol#4459))
([e67d94b](AztecProtocol@e67d94b))
* **docs:** Update private voting tutorial cli commands
([AztecProtocol#4472](AztecProtocol#4472))
([0a8905a](AztecProtocol@0a8905a))
* Parse instance deployed event
([AztecProtocol#4482](AztecProtocol#4482))
([62b171a](AztecProtocol@62b171a))


### Miscellaneous

* Able to run noir-sync manually
([AztecProtocol#4486](AztecProtocol#4486))
([2082fed](AztecProtocol@2082fed))
* **acir:** Move `is_recursive` flag to be part of the circuit
definition (AztecProtocol#4221)
[skip ci]
([4113cfd](AztecProtocol@4113cfd))
* Add bigint solver in ACVM and add a unit test for bigints in Noir
(AztecProtocol#4415)
([4113cfd](AztecProtocol@4113cfd))
* Lift rollup address check & deplot kv-store to npm
([AztecProtocol#4483](AztecProtocol#4483))
([92d0aa4](AztecProtocol@92d0aa4))
* Nuked `OptionallyRevealedData`
([AztecProtocol#4456](AztecProtocol#4456))
([83a3136](AztecProtocol@83a3136))
* Rename bigint_neg into bigint_sub
(AztecProtocol#4420)
([4113cfd](AztecProtocol@4113cfd))
* Replace relative paths to noir-protocol-circuits
([902bbd4](AztecProtocol@902bbd4))
* Surpress chained macro warning
(AztecProtocol#4396)
([4113cfd](AztecProtocol@4113cfd))
* Sync to noir-lang/noir
([4113cfd](AztecProtocol@4113cfd))
* Unhardcode canonical addresses of deployer and registerer contracts
([AztecProtocol#4467](AztecProtocol#4467))
([2c82b62](AztecProtocol@2c82b62))
</details>

<details><summary>barretenberg.js: 0.23.0</summary>

##
[0.23.0](AztecProtocol/aztec-packages@barretenberg.js-v0.22.0...barretenberg.js-v0.23.0)
(2024-02-07)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg: 0.23.0</summary>

##
[0.23.0](AztecProtocol/aztec-packages@barretenberg-v0.22.0...barretenberg-v0.23.0)
(2024-02-07)


### Features

* Add additional error types to verifier contract and revert early
([AztecProtocol#4464](AztecProtocol#4464))
([5e16063](AztecProtocol@5e16063))
* Allow nested arrays and vectors in Brillig foreign calls
([AztecProtocol#4478](AztecProtocol#4478))
([bbfa337](AztecProtocol@bbfa337))
* **avm:** Generic bytecode deserialization
([AztecProtocol#4441](AztecProtocol#4441))
([934fabc](AztecProtocol@934fabc)),
closes
[AztecProtocol#4304](AztecProtocol#4304)
* **bb:** Op counting mode
([AztecProtocol#4437](AztecProtocol#4437))
([5d00cff](AztecProtocol@5d00cff))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
michaelelliot pushed a commit to Swoir/noir_rs that referenced this pull request Feb 28, 2024
This expands on the previous
AztecProtocol#4437 PR with the
ability to automatically microbenchmark pieces.

- If you want to measure timing , uses the preset `op-count-time`
- If you want to measure call counts, uses the preset `op-count-track`

Example of google benchmark running with preset op-count-time
```
------------------------------------------------------------------------------------
Benchmark                          Time             CPU   Iterations UserCounters...
------------------------------------------------------------------------------------
GoblinBench/GoblinFull/1       10609 ms         9065 ms            1 batch_mul_with_endomorphism=48 batch_mul_with_endomorphism(t)=646.575M
^C

-----------------------------------------------------------------------------------
Benchmark                         Time             CPU   Iterations UserCounters...
-----------------------------------------------------------------------------------
GoblinBench/GoblinFull/2      15225 ms        13342 ms            1 batch_mul_with_endomorphism=52 batch_mul_with_endomorphism(t)=1.02146G
```
Note with nanosecond units, one M(illion) is one millisecond, one G(iga)
is one second

---------

Co-authored-by: ludamad <adam@aztecprotocol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants