chore: fix linter issues in AVM

[TomAFrench]

Fixes vscode lighting up whenever I'm in aztec-packages.

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_history_trial_decrypting_time_in_ms (10): 121 (+79%)
• note_successful_decrypting_time_in_ms (32): 531 (-17%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	772	772	772
l1_rollup_calldata_gas	6,832	6,808	6,820
l1_rollup_execution_gas	587,313	587,289	587,301
l2_block_processing_time_in_ms	1,548 (-2%)	5,406 (-5%)	10,372 (+1%)
note_successful_decrypting_time_in_ms	240 (-3%)	⚠️ 531 (-17%)	1,047 (-7%)
note_trial_decrypting_time_in_ms	33.6 (-11%)	35.3 (-7%)	60.9 (-48%)
l2_block_building_time_in_ms	18,763 (-1%)	72,889 (-2%)	145,954 (-1%)
l2_block_rollup_simulation_time_in_ms	18,557 (-1%)	72,148 (-2%)	144,452 (-1%)
l2_block_public_tx_process_time_in_ms	8,512 (-2%)	33,289 (-1%)	66,905 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	16,612 (+1%)	32,453 (+8%)
note_history_successful_decrypting_time_in_ms	1,500 (+10%)	2,841 (+11%)
note_history_trial_decrypting_time_in_ms	40.7 (+21%)	⚠️ 121 (+79%)
node_database_size_in_bytes	20,738,128	37,343,312
pxe_database_size_in_bytes	29,868	59,425

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	158 (+1%)	47,763	31,978
private-kernel-inner	177 (+1%)	80,794	31,978
private-kernel-ordering	137 (+1%)	57,732	49,313
base-parity	9.14 (-1%)	128	265
root-parity	66.6 (+2%)	1,244	265
base-rollup	11,899	110,926	957
root-rollup	49.7	4,551	821
public-kernel-app-logic	1,540	62,017	26,202
public-kernel-tail	4,194 (+1%)	168,566	3,812
merge-rollup	3,167 (-1%)	2,760	957
public-kernel-teardown	120 (+1%)	62,017	34,711
public-kernel-setup	128 (-2%)	62,017	34,711

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	11.0 (+1%)	17.9	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.7	31.8	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.643 (+1%)	0.550	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	51.8	80.0 (-1%)	259 (-2%)	505 (+1%)	980 (-1%)	1,938	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.527	0.494 (-1%)	0.473 (-1%)	0.471	0.465 (-1%)	0.463 (-1%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	60.9	120 (-1%)	375 (-1%)	747 (+1%)	1,466	2,904	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	105	208	692	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.536	0.538 (-1%)	0.510	0.513	0.507	0.507	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	67.2
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	108
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.590

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	51,411	536,920

Transaction size based on fee payment method

Metric	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	897	1,145	1,345

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	1,225 (-2%)	866 (+1%)	3,496

Metric	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	835	759	1,348	899	2,071 (-1%)	1,077

[Maddiaa0]

lgtm

[TomAFrench]

Thanks @Maddiaa0, assuming that you've got perms to bypass branch protections?