fix: quick fix of #6405 by removing context from value note utils

[sklppy88]

Please read contributing guidelines and remove this line.

[sklppy88]

• fix: quick fix of #6405 by removing context from value note utils #6509 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sklppy88 and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• tx_sequencer_processing_time_ms (0): 1,522 (+16%)
• app_circuit_proving_time_in_ms (FPC:fee_entrypoint_public): 8,851 (-46%)
• protocol_circuit_witness_generation_time_in_ms (base-parity): 1,399 (+63%)
• protocol_circuit_proving_time_in_ms (public-kernel-app-logic): 888 (+27%)
• protocol_circuit_proving_time_in_ms (public-kernel-tail): 1,177 (+31%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	740	740	740
l1_rollup_calldata_gas	6,680	6,692	6,692
l1_rollup_execution_gas	586,865	586,877	586,877
l2_block_processing_time_in_ms	1,613	6,060	12,038
l2_block_building_time_in_ms	35,327	139,112 (+1%)	276,077 (-1%)
l2_block_rollup_simulation_time_in_ms	35,105	138,331 (+1%)	274,548 (-1%)
l2_block_public_tx_process_time_in_ms	16,523	70,831 (+1%)	142,525 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	17,866 (-1%)	33,556
node_database_size_in_bytes	21,389,392	38,010,960
pxe_database_size_in_bytes	29,868	59,425

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	protocol_circuit_simulation_time_in_ms	protocol_circuit_witness_generation_time_in_ms	protocol_circuit_proving_time_in_ms	protocol_circuit_input_size_in_bytes	protocol_circuit_output_size_in_bytes	protocol_circuit_proof_size_in_bytes	protocol_circuit_num_public_inputs	protocol_circuit_size_in_gates
private-kernel-init	165 (+1%)	3,566 (-1%)	22,449 (+3%)	20,476	62,438	85,440	2,603	1,048,576
private-kernel-inner	543	4,579 (+5%)	45,100 (-3%)	89,983	62,438	85,440	2,603	2,097,152
private-kernel-reset	1,009	6,245 (-4%)	87,040 (-2%)	330,872	62,438	85,440	2,603	4,194,304
private-kernel-tail	539	4,924 (-3%)	38,487 (-1%)	87,288	79,451	10,656	266	2,097,152
base-parity	8.27 (+1%)	⚠️ 1,399 (+63%)	4,046 (-7%)	128	64.0	2,208	2.00	131,072
root-parity	52.2 (-2%)	134 (-5%)	40,405 (+6%)	27,064	64.0	2,720	18.0	2,097,152
base-rollup	919	5,040 (-11%)	43,218 (-1%)	111,126	925	3,104	30.0	2,097,152
root-rollup	72.7	178 (+3%)	8,419 (+1%)	11,454	789	3,424	40.0	524,288
public-kernel-app-logic	194 (-1%)	297 (-11%)	⚠️ 888 (+27%)	96,951	85,095	113,472	3,479	4,096
public-kernel-tail	891	894 (+11%)	⚠️ 1,177 (+31%)	388,176	7,723	10,144	250	512
public-kernel-setup	165 (-2%)	389 (+6%)	845 (-4%)	137,230	85,095	113,472	3,479	4,096
public-kernel-teardown	166 (+1%)	403 (+4%)	927 (-2%)	142,113	85,095	113,472	3,479	4,096
merge-rollup	6.68 (-2%)	91.4 (+4%)	1,582 (-3%)	2,696	925	3,104	30.0	65,536
private-kernel-tail-to-public	N/A	10,279 (+8%)	68,756	N/A	N/A	113,984	3,495	4,194,304

Stats on running time collected for app circuits

Function	app_circuit_proof_size_in_bytes	app_circuit_proving_time_in_ms	app_circuit_size_in_gates	app_circuit_num_public_inputs
SchnorrAccount:entrypoint	15,520	47,895 (+1%)	2,097,152	418
Test:emit_nullifier	15,520	2,446 (-9%)	65,536	418
FPC:fee_entrypoint_public	15,520	⚠️ 8,851 (-46%)	524,288	418
Token:transfer	15,520	39,436 (+5%)	2,097,152	418
FPC:fee_entrypoint_private	15,520	9,009	524,288	418
Token:unshield	15,520	37,108	2,097,152	418
SchnorrAccount:spend_private_authwit	15,520	2,704	131,072	418

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	13.2	21.5	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.7	31.8	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.772	0.663	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	61.5	97.1	316	608	1,197	2,373	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.631	0.601	0.575	0.568	0.568	0.567	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	73.8	143	456	892	1,776	3,534 (-1%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	106	208	692	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.646	0.644	0.619	0.615	0.617	0.617	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	80.6
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	108
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.709

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	84,440	673,183

Transaction size based on fee payment method

| Metric | |
| - | |

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	37,018 (-1%)	3,686	113,578

Metric	0 public data writes	1 public data writes	2 public data writes	4 public data writes	8 public data writes
tx_sequencer_processing_time_ms	⚠️ 1,522 (+16%)	2,268 (-1%)	1,831 (-4%)	2,826 (-1%)	1,820