Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental deployment uses only first file found under factory folder. #344

Closed
MartaUch opened this issue Jul 12, 2023 · 0 comments
Closed
Assignees
Labels
triage Issue is under investigation

Comments

@MartaUch
Copy link

MartaUch commented Jul 12, 2023

Hello,

I'm still investigating how to enable deployment of global parameters for three different environment and usage of incremental deployment feature. In my case I would have three files under /factory folder:

  • deep-dev-adf-we
  • deep-int-adf-we
  • deep-prd-adf-we

My expectation is that during incremental deployment global parameter "adftools_deployment_state" with hashes will be created in each ADF instance after first initial run on each environment.

I tested the approach on POC environment and I'm running into an issue.
I have currently two files under /factory:

  • deep-dev-adf-we.json
  • deep-poc-dev-adf-we.json

Here are the settings:
image
Two files are recognized:
image
Global parameters are deployed from:
image
Later the step "STEP: Updating (incremental) deployment state..." starts and it takes into account FIRST json file found under the /factory folder:
image
As a result, "adftools_deployment_state" is not deployed to deep-poc-dev-adf-we instance.

I was trying to find this part in the code and what I found so far is that we take always first object from factories:
image

QUESTION

  • Is it possible to change the approach and not assume that there is always one Factory file or it would require a big refactoring of the code?

Thank you in advance!
Marta

@MartaUch MartaUch added the triage Issue is under investigation label Jul 12, 2023
@MartaUch MartaUch changed the title Incremental deployment uses only first files found under factory folder. Incremental deployment uses only first file found under factory folder. Jul 12, 2023
@NowinskiK NowinskiK self-assigned this Jul 13, 2023
@Azure-Player Azure-Player locked and limited conversation to collaborators Jul 13, 2023
@NowinskiK NowinskiK converted this issue into discussion #347 Jul 13, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
triage Issue is under investigation
Projects
None yet
Development

No branches or pull requests

2 participants