Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hack-together] Sign-in buttons options can have some style like logos ..etc #292

Closed
1 task
Surya-V-28 opened this issue Aug 20, 2023 · 2 comments
Closed
1 task

[Hack-together] Sign-in buttons options can have some style like logos ..etc #292

Surya-V-28 opened this issue Aug 20, 2023 · 2 comments
Assignees
@juliamuiruri4
Labels
Hack-together:accepted Accepted after triage and ready for to be done Hack-together

Comments

@Surya-V-28
Copy link
Contributor

Are you accessing the project from the GitHub Codespaces?

  • No, I am running the project on my local machine (I will fill in the OS section below)
  • [ Yes] Yes, I am using GitHub Codespaces.

Note: The project is optimized to run on Codespaces. We welcome contributions to enhance it for cross-platform local development, but it's not something we will prioritize right now. Thank you!

Describe the bug
Instead just the name of the Sign options we can add some style as in logo of the sign option providers

To Reproduce
you can use the CSS file for adding the logos and some padding would be better

  1. Go to Login Page
  2. See the options

Expected behavior
this would looks nice if its done

image

Additional context
Add any other context to improve the page look.
@Surya-V-28
Copy link
Contributor Author

@juliamuiruri4 I would like work on this with @YaminNather as team? can you assign this to me ?

@anfibiacreativa anfibiacreativa added Hack-together:accepted Accepted after triage and ready for to be done and removed status: needs triage labels Aug 23, 2023
@anfibiacreativa
Copy link
Member

Thanks for reporting this issue! Looking forward to your contributions.

Surya-V-28 added a commit to Surya-V-28/contoso-real-estate-trails that referenced this issue Aug 28, 2023
@Surya-V-28
style: added the logos on loginpage Azure-Samples#292
f880ec1
This was referenced Aug 28, 2023
Closed
Merged
manekinekko added a commit that referenced this issue Sep 12, 2023
@Surya-V-28 @manekinekko
fix(portal): update icons in login page #292 (#323)
f28f7b6 
* style: added the logos on loginpage #292

* style: add-logos-register-page-292

* Update index.html on requested 

Removed the material icons link sheet

* Update authentication.component.scss

Resolved the conflicts

* Update package.json

updatethe package version apollo angular

---------

Co-authored-by: Wassim Chegham <github@wassim.dev>
devin-ai-integration bot pushed a commit to altsang/contoso-real-estate that referenced this issue May 14, 2024
@Surya-V-28 @manekinekko
fix(portal): update icons in login page Azure-Samples#292 (Azure-Samp…
b1f661e 
…les#323)

* style: added the logos on loginpage Azure-Samples#292

* style: add-logos-register-page-292

* Update index.html on requested 

Removed the material icons link sheet

* Update authentication.component.scss

Resolved the conflicts

* Update package.json

updatethe package version apollo angular

---------

Co-authored-by: Wassim Chegham <github@wassim.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juliamuiruri4 juliamuiruri4

Labels
Hack-together:accepted Accepted after triage and ready for to be done Hack-together
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@anfibiacreativa @juliamuiruri4 @Surya-V-28