Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style:Logos-added-register-page-#292 #323

Merged
merged 6 commits into from
Sep 12, 2023

Conversation

Surya-V-28
Copy link
Contributor

@Surya-V-28 Surya-V-28 commented Aug 30, 2023

made the changes on the previous PR #313 ,
image

Please take a look at the PR . the issues PR #292
I am open to any suggestion to make it more better, Let me know if there are any issues with it

@anfibiacreativa , @juliamuiruri4 ,@manekinekko, @sinedied

Copy link
Contributor

@sinedied sinedied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the small comment

packages/portal/src/index.html Outdated Show resolved Hide resolved
Removed the material icons link sheet
@anfibiacreativa anfibiacreativa added the Hack-together: pending-final-review The PR's with this label were submitted before the 31st EOB and may still be merged (if approved) label Aug 31, 2023
@manekinekko manekinekko self-assigned this Sep 7, 2023
@manekinekko
Copy link
Collaborator

Hi @Surya-V-28 any updates for this PR?

@Surya-V-28
Copy link
Contributor Author

@manekinekko , I think it has no issues to merge , I have made the requested changes if any new needed let me know, i think its okay to merge

updatethe package version apollo angular
manekinekko
manekinekko previously approved these changes Sep 12, 2023
@manekinekko manekinekko merged commit f28f7b6 into Azure-Samples:main Sep 12, 2023
@manekinekko
Copy link
Collaborator

Merged! Thank you @Surya-V-28!

@manekinekko manekinekko added Hack-together:accepted Accepted after triage and ready for to be done and removed Hack-together:awaiting-feedback Awaiting feedback from participant Hack-together: pending-final-review The PR's with this label were submitted before the 31st EOB and may still be merged (if approved) labels Sep 12, 2023
devin-ai-integration bot pushed a commit to altsang/contoso-real-estate that referenced this pull request May 14, 2024
…les#323)

* style: added the logos on loginpage Azure-Samples#292

* style: add-logos-register-page-292

* Update index.html on requested 

Removed the material icons link sheet

* Update authentication.component.scss

Resolved the conflicts

* Update package.json

updatethe package version apollo angular

---------

Co-authored-by: Wassim Chegham <github@wassim.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hack-together:accepted Accepted after triage and ready for to be done Hack-together
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants