Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: added the logos on login-page #292 #313

Closed

Conversation

Surya-V-28
Copy link
Contributor

@Surya-V-28 Surya-V-28 commented Aug 28, 2023

Please take a look a the given images below , I have added the logos for the each login providers
This is the issue #292
https://drive.google.com/file/d/1_ewaurlUEqJoL4vPGrjcYjb8jPocGRfH/view?usp=drive_link

I am open to any suggestion to make it more better, Let me know if there are any issues with it

@anfibiacreativa , @juliamuiruri4 ,@manekinekko, @sinedied

@Surya-V-28 Surya-V-28 changed the title style: added the logos on loginpage #292 style: added the logos on login-page #292 Aug 28, 2023
Copy link
Member

@anfibiacreativa anfibiacreativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! Thanks for your contribution!
For compliance reasons involving trademarks, it may be a better option to use the material icons versions: https://v7.material.angular.io/components/icon/overview

@anfibiacreativa anfibiacreativa self-assigned this Aug 28, 2023
@anfibiacreativa anfibiacreativa added Hack-together Hack-together:accepted Accepted after triage and ready for to be done status: blocked Unable to progress on a work item Hack-together:awaiting-feedback Awaiting feedback from participant and removed Hack-together:accepted Accepted after triage and ready for to be done labels Aug 28, 2023
@Surya-V-28
Copy link
Contributor Author

@anfibiacreativa , I checked for material icons only first before using those the svg files since Material icons don't have social media icons. any alternative we can go ahead ? let me know

@anfibiacreativa
Copy link
Member

@anfibiacreativa , I checked for material icons only first before using those the svg files since Material icons don't have social media icons. any alternative we can go ahead ? let me know

You can try to use Font Awesome that has all social media icons. https://fontawesome.com/search?q=facebook&o=r
https://origin.fontawesome.com/docs/web/use-with/angular

You need to install Font Awesome and then reference it in the mat-icon like this
<mat-icon fontSet="fa" fontIcon="fa-facebook"></mat-icon>

I would need to check if that is in CELA (legal/copyrights) compliance, however, before merging your PR. I apologize for the inconvenience!

@sinedied
Copy link
Contributor

Closing this as there's #323 with the updated version

@sinedied sinedied closed this Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hack-together:awaiting-feedback Awaiting feedback from participant Hack-together status: blocked Unable to progress on a work item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants