Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module Proposal]: avm/res/network/application-gateway (bicep) #258

Closed
2 tasks done
ilhaan opened this issue Nov 2, 2023 · 16 comments
Closed
2 tasks done

[Module Proposal]: avm/res/network/application-gateway (bicep) #258

ilhaan opened this issue Nov 2, 2023 · 16 comments
Assignees
Labels
Class: Resource Module 📦 This is a resource module Language: Bicep 💪 This is related to the Bicep IaC language Needs: Module Contributor 📣 This module needs secondary owner(s) or contributor(s) to develop or maintain it Status: Migrate from CARML 🚛 This item is related to a module migration from CARML Status: Module Available 🟢 The module is published Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed

Comments

@ilhaan
Copy link
Member

ilhaan commented Nov 2, 2023

Check for previous/existing GitHub issues/module proposals

  • I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

  • I have checked for that this module doesn't already exist in the module indexes; or I'm proposing the module to be migrated from CARML/TFVM.

Bicep or Terraform?

Bicep

Module Classification?

Resource Module

Module Name

avm/res/network/application-gateway

Module Details

Module that deploys Azure Application Gateway resource

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

ilhaan

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

@ilhaan ilhaan added Needs: Triage 🔍 Maintainers need to triage still Type: New Module Proposal 💡 A new module for AVM is being proposed labels Nov 2, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Language: Bicep 💪 This is related to the Bicep IaC language label Nov 2, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Owners Identified 🤘 This module has its owners identified label Nov 2, 2023
@matebarabas matebarabas added Status: Migrate from CARML 🚛 This item is related to a module migration from CARML Status: In Triage 🔍 Picked up for triaging by an AVM core team member Class: Resource Module 📦 This is a resource module labels Nov 2, 2023
@matebarabas
Copy link
Contributor

Hi @ilhaan,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

#RR


NOTE:

  • This Module Proposal issue MUST remain open until the module is fully developed, tested and published to the relevant registry. Do NOT close the issue before the successful publication is confirmed!
  • Once the module is fully developed, tested and published to the relevant registry, and the Module Proposal issue was closed, it MUST remain closed.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author label Nov 2, 2023
@ilhaan
Copy link
Member Author

ilhaan commented Nov 3, 2023

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Nov 3, 2023
@matebarabas
Copy link
Contributor

Hi @ilhaan,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

We just want to ask you to double check a few important things and take the next steps before you start the development.

Please use the following values explicitly as provided in the module index page:

  • For your module:
    • ModuleName - to name your module
    • TelemetryIdPrefix - to be used in your module's telemetry
  • For your module's repository:
    • Repository name and folder path are defined in RepoURL
    • Create the GitHub teams defined in the ModuleOwnersGHTeam and ModuleContributorsGHTeam columns and grant them permissions as described here.
      • In case of a Bicep module, please let the AVM core team know when you created these teams, and we'll help you with assigning the necessary permissions as described here.
      • In case of a Terraform module, follow the instructions here and assign the necessary permissions.

Grant the right level of permissions for the AVM core team and PG teams on your GitHub repo as described here.

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR if available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team


NOTE:

  • This Module Proposal issue MUST remain open until the module is fully developed, tested and published to the relevant registry. Do NOT close the issue before the successful publication is confirmed!
  • Once the module is fully developed, tested and published to the relevant registry, and the Module Proposal issue was closed, it MUST remain closed.

@matebarabas matebarabas removed Needs: Attention 👋 Reply has been added to issue, maintainer to review Needs: Triage 🔍 Maintainers need to triage still Status: In Triage 🔍 Picked up for triaging by an AVM core team member labels Nov 4, 2023
@matebarabas matebarabas changed the title [Module Proposal]: avm-res-network-applicationgateway (bicep) [Module Proposal]: avm/res/network/application-gateway Nov 6, 2023
@matebarabas
Copy link
Contributor

ilhaan,

Due to a recent change in the naming convention for AVM Bicep modules, this module is getting an updated name.

The title and description of this GH issue has been updated to reflect the name change. Please make sure you adhere to the new naming convention when publishing your module!

Please see the new naming convention in:

Please note that the Telemetry ID and name of GitHub Teams haven't changed.

If you feel uncertain about any details, please check the Bicep modules indexes.

@ilhaan
Copy link
Member Author

ilhaan commented Nov 7, 2023

@jeanchg jeanchg changed the title [Module Proposal]: avm/res/network/application-gateway [Module Proposal]: avm/res/network/application-gateway (bicep) Nov 8, 2023
@matebarabas
Copy link
Contributor

I've just requested the -owners- team to be added to the -technical-reviewers- team. Please approve.

@ilhaan
Copy link
Member Author

ilhaan commented Dec 1, 2023

@matebarabas approved

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Dec 22, 2023
@matebarabas
Copy link
Contributor

@ilhaan, I just would like to check back on this issue and ask how far do you think you are? Can you please share your expected timeline on publishing this module? Is there anything you need help with?

Thank you!

CC: @jeanchg

@ilhaan
Copy link
Member Author

ilhaan commented Jan 12, 2024

@matebarabas I should be able to send out an initial PR by the end of next week.

@matebarabas matebarabas removed the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Jan 12, 2024
@matebarabas
Copy link
Contributor

That's great news, thanks for the update!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Feb 3, 2024
@matebarabas
Copy link
Contributor

Draft PR: Azure/bicep-registry-modules#835

@ilhaan
Copy link
Member Author

ilhaan commented Feb 14, 2024

Still working on this

@matebarabas matebarabas removed the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Feb 14, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Mar 6, 2024
@ilhaan
Copy link
Member Author

ilhaan commented Mar 8, 2024

Still working on this

@ilhaan
Copy link
Member Author

ilhaan commented Apr 15, 2024

Still working on this. Draft PR here: Azure/bicep-registry-modules#835

@matebarabas matebarabas added Status: In PR 👉 This is when an issue is due to be fixed in an open PR and removed Needs: Attention 👋 Reply has been added to issue, maintainer to review labels Apr 17, 2024
@ilhaan
Copy link
Member Author

ilhaan commented Apr 17, 2024

PR ready for review: Azure/bicep-registry-modules#835

@matebarabas matebarabas added Status: Module Available 🟢 The module is published and removed Status: In PR 👉 This is when an issue is due to be fixed in an open PR labels Apr 19, 2024
@matebarabas
Copy link
Contributor

  • Module published.
  • GitHub teams are available and assigned to their parents.
  • CODEOWNERS file updated.

Thank you for your work @ilhaan! I'm closing this issue now.

@matebarabas matebarabas added the Needs: Module Contributor 📣 This module needs secondary owner(s) or contributor(s) to develop or maintain it label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Language: Bicep 💪 This is related to the Bicep IaC language Needs: Module Contributor 📣 This module needs secondary owner(s) or contributor(s) to develop or maintain it Status: Migrate from CARML 🚛 This item is related to a module migration from CARML Status: Module Available 🟢 The module is published Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed
Projects
Development

No branches or pull requests

2 participants