Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module Proposal]: avm-res-servicenetworking-trafficcontroller (tf) #711

Open
2 tasks done
shailwx opened this issue Mar 4, 2024 · 23 comments
Open
2 tasks done

[Module Proposal]: avm-res-servicenetworking-trafficcontroller (tf) #711

shailwx opened this issue Mar 4, 2024 · 23 comments
Assignees
Labels
Class: Resource Module 📦 This is a resource module Language: Terraform 🌐 This is related to the Terraform IaC language Needs: Attention 👋 Reply has been added to issue, maintainer to review Status: External Contribution 🌍 This is being worked on by someone outside of the AVM module owners/contributors or AVM core team Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed

Comments

@shailwx
Copy link

shailwx commented Mar 4, 2024

Check for previous/existing GitHub issues/module proposals

  • I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

  • I have checked for that this module doesn't already exist in the module indexes; or I'm proposing the module to be migrated from CARML/TFVM.

Bicep or Terraform?

Terraform

Module Classification?

Resource Module

Module Name

avm-res-servicenetworking-trafficcontroller

Module Details

Application Gateway for Containers (Traffic Controller)

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

shailwx

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

@shailwx shailwx added Needs: Triage 🔍 Maintainers need to triage still Type: New Module Proposal 💡 A new module for AVM is being proposed labels Mar 4, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Language: Terraform 🌐 This is related to the Terraform IaC language label Mar 4, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Owners Identified 🤘 This module has its owners identified label Mar 4, 2024
@shailwx shailwx changed the title avm-res-network-applicationgatewayforcontainers Application Gateway for Containers Mar 4, 2024
@shailwx shailwx changed the title Application Gateway for Containers [Module Proposal] : Application Gateway for Containers Mar 4, 2024
@mbilalamjad
Copy link
Contributor

Hi @shailwx thank you for the module proposal, a couple of observations.

  1. Module name should be following the naming pattern appreciate if you could update it accordingly for us to triage the proposal
  2. This might be covered already in the application gateway module being developed.
  3. In case you believe the above point isn't true and this needs to exist as a separate module than we would need to find a Microsoft FTE as the owner as that is a requirement for AVM

@mbilalamjad mbilalamjad added Status: In Triage 🔍 Picked up for triaging by an AVM core team member and removed Needs: Triage 🔍 Maintainers need to triage still labels Mar 5, 2024
@mbilalamjad mbilalamjad added Needs: Module Owner 📣 This module needs an owner to develop or maintain it and removed Status: Owners Identified 🤘 This module has its owners identified labels Mar 5, 2024
@prjelesi
Copy link
Contributor

@shailwx Thanks for proposing. We will search for MSFT FTE to own module. Would you like to contribute to development of this module?

@shailwx
Copy link
Author

shailwx commented Mar 24, 2024

@prjelesi, sure no problem. Yes I would like to contribute to the development of this module

@mofaizal
Copy link

The service become GA last week, we should include part of avm-res-network-applicationgateway I don't we need to separate module for this.

@prjelesi
Copy link
Contributor

@mofaizal this should be different resource type. Pls correct me if I am wrong?

@mofaizal
Copy link

Yes, and agree. I notice this is fall under different resource tree, I thought this is part of networking, but this is fall under Service Networking. We should have different TF module for this.

@prjelesi
Copy link
Contributor

Thanks @mofaizal ,

Since you mention that you are open to own this module:

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

#RR

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author label Mar 28, 2024
@matebarabas
Copy link
Contributor

@prjelesi, please note the related Bicep issue (I linked above): #712. The module name should be aligned with the Bicep equivalent. Please update this issue's name and its description to reflect this too. Thanks!

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author label Mar 30, 2024

Note

The "Needs: Author Feedback 👂" label was removed and the "Needs: Attention 👋" label was added as per ITA11.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Mar 30, 2024
@mofaizal
Copy link

mofaizal commented Apr 1, 2024

@prjelesi Thanks and "I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

@prjelesi prjelesi changed the title [Module Proposal] : Application Gateway for Containers [Module Proposal] : avm-res-servicenetworking-trafficcontroller Apr 4, 2024
@prjelesi
Copy link
Contributor

prjelesi commented Apr 4, 2024

@mofaizal , @shailwx module name is updated,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

For your module:
ModuleName - for naming your module
TelemetryIdPrefix - for your module's telemetry
For your module's repository:
Repo name and folder path are defined in RepoURL
Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.
Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

@prjelesi prjelesi removed Needs: Attention 👋 Reply has been added to issue, maintainer to review Needs: Module Owner 📣 This module needs an owner to develop or maintain it labels Apr 4, 2024
@prjelesi prjelesi added Status: External Contribution 🌍 This is being worked on by someone outside of the AVM module owners/contributors or AVM core team Status: Owners Identified 🤘 This module has its owners identified Class: Resource Module 📦 This is a resource module labels Apr 4, 2024
@shailwx
Copy link
Author

shailwx commented Apr 9, 2024

Thanks @prjelesi, @mofaizal

@mofaizal , should we setup our first meeting to get started on this ?

@prjelesi prjelesi self-assigned this Apr 23, 2024
@matebarabas
Copy link
Contributor

@mofaizal, I just pinged you via Teams internally. Please continue by setting up a Teams call with @shailwx - I've shared all details. Thank you!

@prjelesi prjelesi assigned mofaizal and unassigned prjelesi Apr 23, 2024
@prjelesi prjelesi removed the Status: In Triage 🔍 Picked up for triaging by an AVM core team member label Apr 23, 2024
@mofaizal
Copy link

mofaizal commented May 7, 2024

@prjelesi and @matebarabas I had a teams meeting with @shailwx on this TF module. Created private repo and given access to @shailwx to develop module.

https://github.com/Azure/avm-res-servicenetworking-trafficcontroller

@shailwx. Thanks for your support and helping us. Let me know when you are ready happy to jump on call to take a look.

Important

@mofaizal, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

Tip

To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term ⏳" label.

Note

This message was posted as per ITA24.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Reply has been added to issue, maintainer to review label May 28, 2024

Important

@mofaizal, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

Tip

To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term ⏳" label.

@mofaizal
Copy link

mofaizal commented Jun 18, 2024

@prjelesi Thanks for the follow up, i setup a repo and got deleted due to internal policy. Will setup again

Important

@mofaizal, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

Tip

To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term ⏳" label.

@mofaizal
Copy link

Back from vacation will look into this and update soon

Important

@mofaizal, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

Tip

To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term ⏳" label.

@matebarabas matebarabas changed the title [Module Proposal] : avm-res-servicenetworking-trafficcontroller [Module Proposal]: avm-res-servicenetworking-trafficcontroller (tf) Aug 15, 2024

Important

@mofaizal, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

Tip

To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term ⏳" label.

2 similar comments

Important

@mofaizal, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

Tip

To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term ⏳" label.

Important

@mofaizal, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

Tip

To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term ⏳" label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Language: Terraform 🌐 This is related to the Terraform IaC language Needs: Attention 👋 Reply has been added to issue, maintainer to review Status: External Contribution 🌍 This is being worked on by someone outside of the AVM module owners/contributors or AVM core team Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed
Projects
Status: In development
Development

No branches or pull requests

5 participants