Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node pricing not showing up for manual pool creation #1562

Closed
ascobie opened this issue Aug 27, 2018 · 3 comments
Closed

Node pricing not showing up for manual pool creation #1562

ascobie opened this issue Aug 27, 2018 · 3 comments

Comments

@ascobie
Copy link
Member

ascobie commented Aug 27, 2018

The node price is not showing up in the VM picker table. At SIGGRAPH it was working for 17.1, but there were some new NC prices missing, but now, nothing seems to be showing up at all.

And while we are here ...

  • NC_V2 machines are not showing up in the GPU tab.
  • Compute Optimized shows (12), but nothing is in the list

Pool pricing is also not showing. This was also working at SIGGRAPH:

image

@ascobie
Copy link
Member Author

ascobie commented Aug 27, 2018

Update

Looks like the pricing API result has changed based on what is in our codebase:

    public getVMPrices(vmsize: string): VMPrices {
        vmsize = vmsize.toLowerCase();
        if (!this._map.has(vmsize)) {
            return null;
        }
        return this._map.get(vmsize);
    }

The _map contains this:

image

But we are looking for this._map.has('standard_d3_v2') which is clearly not going to work based on what is actually in the map.

And another update

Can confirm that this is the source of all the pricing issues. Hard coded it to return return this._map.get("dv2/dsv2"); and we get a price in the pool creation table as well as the pool details price.

@ascobie
Copy link
Member Author

ascobie commented Aug 27, 2018

This is also interesting. Only pricing for Linux nodes is coming back. Windows pricing seems to only consist of standard_d40_v3 for every region.

image

@timotheeguerin timotheeguerin added this to the 0.17.3 milestone Aug 29, 2018
@timotheeguerin
Copy link
Member

This looks like rate card api made AGAIN a breaking change without changing version....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants