Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(designer): html editor styles not showing in v3 #4627

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

AfroJoe759
Copy link
Contributor

@AfroJoe759 AfroJoe759 commented Apr 16, 2024

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)

  • Current behavior is that for the new designer, the HTML editor adds
    tags anyplace where there is new lines which results in malformed outputs (spaces where there shouldn't be) and malformed tags resulting in styles defined in a tag to not render. The malformed HTML also appears when a user reopens a flow and checks the HTML editor.

  • What is the new behavior (if this is a feature change)?


  • tags aren't replacing newline (\n) characters anymore, which fixes malformed HTML outputs and allows styles that aren't defined inline to be applied, which matches the bahavior of the older designer.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    N/A

  • Please Include Screenshots or Videos of the intended change:
    The bug itself contains a more detailed example and explanation of the above, but here's a simple example of the difference before and after my change.

Link to bug: https://msazure.visualstudio.com/One/_workitems/edit/27066057/

Before Change Screenshot
image

After Change Screenshot
image

@hartra344
Copy link
Contributor

@Eric-B-Wu can you review this one?

@Eric-B-Wu
Copy link
Contributor

@Eric-B-Wu can you review this one?

yeah im just confirming on our end this doesn't break anything I think in general we wanted to keep anything in the html editor strictly in HTML-form

@Eric-B-Wu
Copy link
Contributor

From what I'm seeing this is only happening in the conversion between html editor and raw html editor. I'm not seeing any consequences for us - however, because @ek68794998 was the one who worked on the raw html editor, he would know better if there are side effects. I'm going to approve so this doesn't block, but would like input from the other Eric once he's back

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hartra344 do you know why these localization strings were deleted? they seem to be still in use; however, Joe mentioned that this was added on commit/push

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's something up with them getting pushed when generated on commit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hartra344 @Eric-B-Wu do you want me to revert that specific file to what it is in the main branch?

@Eric-B-Wu Eric-B-Wu changed the title Bug: html editor styles not showing in v3 fix(designer): html editor styles not showing in v3 Apr 16, 2024
@ek68794998
Copy link
Contributor

ek68794998 commented Apr 17, 2024 via email

@hartra344 hartra344 merged commit 85430e3 into Azure:main Apr 17, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants