Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix depends on errors #2059

Merged
merged 21 commits into from
Nov 11, 2020
Merged

Fix depends on errors #2059

merged 21 commits into from
Nov 11, 2020

Conversation

larohra
Copy link
Contributor

@larohra larohra commented Nov 2, 2020

Description

This PR takes care of a couple of things -

  • For depends-on feature, we first check the handler status and then start polling for the extension status in order to fail fast if the handler already failed for some reason.
  • Improved error handling around the depends-on scenario. Currently if any errors are thrown in the wait_for_handler_successful_completion function, we can go on an infinite error reporting loop until a new goalstate comes in. This can blast Kusto, fill up logs and hide the original issue.
  • Modified the logic for fetching SeqNo from File-System and added plans to eventually deprecate that function (we should only rely on seqNo from the GoalState rather than the filesystem)

TFS bugs -

  • Bug 7101306: Wrongfully waiting for dependent extension status if extension installation failed
  • Bug 7101366: Wrongfully waiting for 90 mins even though the extension timedout after 15mins

Issue #

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines

narrieta
narrieta requested changes Nov 3, 2020
View reviewed changes
azurelinuxagent/ga/exthandlers.py Outdated Show resolved Hide resolved
narrieta
narrieta reviewed Nov 6, 2020
View reviewed changes
Copy link
Member

@narrieta narrieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor comments

azurelinuxagent/ga/exthandlers.py Outdated Show resolved Hide resolved
azurelinuxagent/ga/exthandlers.py Outdated Show resolved Hide resolved
azurelinuxagent/ga/exthandlers.py Show resolved Hide resolved
pgombar
pgombar previously approved these changes Nov 9, 2020
View reviewed changes
@larohra
Merge remote-tracking branch 'upstream/develop' into fix-depends-on-e…
2e066ff 
…rrors

# Conflicts:
#	azurelinuxagent/ga/exthandlers.py
@larohra
Moved incarnation check one up
bdf2f24
@larohra
Merge remote-tracking branch 'upstream/develop' into fix-depends-on-e…
92abf18 
…rrors

# Conflicts:
#	azurelinuxagent/ga/exthandlers.py
#	tests/ga/test_extension.py
#	tests/ga/test_exthandlers.py
@larohra larohra merged commit 7c31749 into Azure:develop Nov 11, 2020
@larohra larohra deleted the fix-depends-on-errors branch November 11, 2020 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narrieta narrieta narrieta approved these changes

@pgombar pgombar pgombar approved these changes

@kevinclark19a kevinclark19a Awaiting requested review from kevinclark19a

@ZhidongPeng ZhidongPeng Awaiting requested review from ZhidongPeng ZhidongPeng is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@larohra @narrieta @pgombar