-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for VMs with multiple IB devices #2085
Conversation
6524cb8
to
881ca2a
Compare
running automation |
automation ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added few comments
Hey @longlimsft, any update on the PR? Feel free to ping me if you need any clarification about any of my comments above! |
Newer HPC VM supports multiple Infiniband NICs. A new KVP format is introduced in KVP pool0 to pass multiple IPs from KVP daemon. The KVP is of format: (e.g passing two IPs to two IB) key name: IPoIB_Data value: NUMPAIRS:2|FFFFFFFFFFF1:172.16.0.1|FFFFFFFFFFF2:172.16.0.2 FFFFFFFFFFF1 and FFFFFFFFFFF2 are the MAC address for the IP over IB device. 172.16.0.1 and 172.16.0.2 are their respective IPs. If this key is not present in the KVP pool0, the Linux agent falls back to the old code path of provisioning a single IB device, thus maintaining compatiblity with older HPC VMs.
I have updated the pull request. Please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 very small comment else LGTM. Will run DCR automation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automation ok, LGTM
Newer HPC VM supports multiple Infiniband NICs. A new KVP format is
introduced in KVP pool0 to pass multiple IPs from KVP daemon. The KVP
is of format: (e.g passing two IPs to two IB)
key name: IPoIB_Data
value: NUMPAIRS:2|FFFFFFFFFFF1:172.16.0.1|FFFFFFFFFFF2:172.16.0.2
FFFFFFFFFFF1 and FFFFFFFFFFF2 are the MAC address for the IP over IB device.
172.16.0.1 and 172.16.0.2 are their respective IPs.
If this key is not present in the KVP pool0, the Linux agent falls back to
the old code path of provisioning a single IB device, thus maintaining
compatiblity with older HPC VMs.
Description
Issue #
PR information
Quality of Code and Contribution Guidelines