Environment-variables and secure-environment-variables now parsed according to action.yml #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I've spent 2 days trying to get my Container Instance to talk to a Postgres server where I have to pass a PG connection string. I was unsure if the problem was with Github secrets, Github actions, This action or with the Azure API.
The connection string is defined in the format of
PG_DSN=postgres://user:pass@hostname/dbname?sslmode=require
orPG_DSN=host=hostname user=myuser password=mypassword
Both of these strings cause issues for the naive
string.split(' ')
andstring.split('=')
approach used currently.The
action.yml
says that if you use spaces, you should add quotes, but I can't see that these quotes are handled anywhere.Changes
parseForPairs()
andparsePair()
utility functions and changed how the environment variables are parsed.Comments
I just hope this will help the next person trying to use database connection strings with this action. Please give it a read and see if this can be used.