Environment Variable Separation logic

[shubham1172]

This PR is based on #10

Splitting '='

Fix by @yuhattor - only split the first instance of '=' instead of all.
Edit: Added another logic to parse values with optional quotes around them.

Original

"key=foobarbaz123=".split('=')
>> Array(3) [ "key", "foobarbaz123", "" ]

Modified

"key=foobarbaz123=".split(/=(?:"(.+)"|(.+))/)
>> Array(3) [ "key", "foobarbaz123=", "" ]

Original

"key=\"foo bar baz 123\"=".split('=')
>> Array(3) [ "key", "\"foo bar baz 123\"", "" ]

Modified

"key=\"foo bar baz 123=\"".split(/=(?:"(.+)"|(.+))/)
>> Array(4) [ "key", "foo bar baz 123=", undefined, "" ]

Splitting whitespace

New fix - do not account for whitespaces that are inside quotes while splitting.

Original

"key1=\"foo bar\" key2=baz".split(' ');
>> Array(3) [ "key1=\"foo", "bar\"", "key2=baz" ]

Modified

"key1=\"foo bar\" key2=baz".match(/(?:[^\s"]+|"[^"]*")+/g) || []
>> Array [ "key1=\"foo bar\"", "key2=baz" ]

[shubham1172]

I will be willing to add test cases for the same. I wonder if this can be a good point to set up tests for this repository - provided you have that bandwidth.

[ashishonce]

Hey Shubham,
although the pattern looks ok.
when I try this rex pattern , I get an extra " , which is unescaped , would mean extra " coming in the value .

am I missing something, or we want to look at this again.
I want to make sure this won't come for any user.

do you have any working example with new code for this?

[shubham1172]

Oops @ashishonce, I missed that. Updating the splitting on '=' logic to consider quotes around values.

I have written some tests here, please feel free to checkout https://jsfiddle.net/06yn3zw9/3/

[ashishonce]

LGTM
we should also think about adding unit test for this .
@narula0781 can we add this to backlog?

[shubham1172]

@ashishonce, I would be happy to volunteer for writing unit tests for this.

[ashishonce]

@ashishonce, I would be happy to volunteer for writing unit tests for this.

thanks @shubham1172 . let's merge this PR and then you can add a test if required.