This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: userAssignedIdentityId in windows azure.json missing quotes #2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2327 +/- ##
=======================================
Coverage 71.73% 71.73%
=======================================
Files 142 142
Lines 24992 24992
=======================================
Hits 17927 17927
Misses 5934 5934
Partials 1131 1131 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma, xizhamsft The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Azure DevOps seems not to have updated the overall "pr-e2e" job status, although all the actual test jobs passed. Merging... |
jackfrancis
pushed a commit
that referenced
this pull request
Nov 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
The userAssignedIdentity property in azure.json for windows does not have quotes around the values. So when the value is empty string, you will get the following line in the json:
"userAssignedIdentityID": ,
That is a syntax error.
Issue Fixed:
Requirements:
Notes: