-
Notifications
You must be signed in to change notification settings - Fork 522
feat: update containermonitoring addon for february 2020 release #2850
Conversation
* changes for feb agent release
/assign @jackfrancis |
/assign @devigned |
var workspaceDomain string | ||
if cs.Properties.IsAzureStackCloud() { | ||
dependenciesLocation := string(cs.Properties.CustomCloudProfile.DependenciesLocation) | ||
workspaceDomain = helpers.GetLogAnalyticsWorkspaceDomain(dependenciesLocation) | ||
if strings.EqualFold(dependenciesLocation, "china") { | ||
omsagentImage = "dockerhub.azk8s.cn/microsoft/oms:ciprod01072020" | ||
omsagentImage = "dockerhub.azk8s.cn/microsoft/oms:ciprod03022020" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jadarsie just curious, why are we using a .cn URL in an Azure Stack context for this addon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nevermind, this logic is a little kloodgy, but I see what's going on
/azp run pr-e2e |
Commenter does not have sufficient privileges for PR 2850 in repo Azure/aks-engine |
/azp run pr-e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #2850 +/- ##
=======================================
Coverage 72.47% 72.47%
=======================================
Files 140 140
Lines 25612 25612
=======================================
Hits 18562 18562
Misses 5981 5981
Partials 1069 1069
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
February 2020 release changes for Containermonitoring addon -
feat: GPU metrics collection
feat: Support for user assigned msi
feat: Query kubelet to get limits
Complete set of changes here - https://github.com/microsoft/Docker-Provider/blob/ci_feature_prod/README.md