This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
feat: update containermonitoring addon for february 2020 release #2850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* changes for feb agent release
|
/assign @jackfrancis |
|
/assign @devigned |
jackfrancis
reviewed
Mar 6, 2020
| var workspaceDomain string | ||
| if cs.Properties.IsAzureStackCloud() { | ||
| dependenciesLocation := string(cs.Properties.CustomCloudProfile.DependenciesLocation) | ||
| workspaceDomain = helpers.GetLogAnalyticsWorkspaceDomain(dependenciesLocation) | ||
| if strings.EqualFold(dependenciesLocation, "china") { | ||
| omsagentImage = "dockerhub.azk8s.cn/microsoft/oms:ciprod01072020" | ||
| omsagentImage = "dockerhub.azk8s.cn/microsoft/oms:ciprod03022020" |
There was a problem hiding this comment.
@jadarsie just curious, why are we using a .cn URL in an Azure Stack context for this addon?
There was a problem hiding this comment.
nevermind, this logic is a little kloodgy, but I see what's going on
|
/azp run pr-e2e |
|
Commenter does not have sufficient privileges for PR 2850 in repo Azure/aks-engine |
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #2850 +/- ##
=======================================
Coverage 72.47% 72.47%
=======================================
Files 140 140
Lines 25612 25612
=======================================
Hits 18562 18562
Misses 5981 5981
Partials 1069 1069
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
February 2020 release changes for Containermonitoring addon -
feat: GPU metrics collection
feat: Support for user assigned msi
feat: Query kubelet to get limits
Complete set of changes here - https://github.com/microsoft/Docker-Provider/blob/ci_feature_prod/README.md