Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: do not remove VMAS resources from template when adding a VMAS pool #2907

Merged
merged 2 commits into from
Mar 18, 2020

Conversation

jadarsie
Copy link
Member

Reason for Change:
Template normalization broke for addppols operations that try to create a VMAS pool.
The normalization function is removing VMAS resources.
Pushing a new normalization function that does not remove VMAS resources.

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #2907 into master will decrease coverage by 0.03%.
The diff coverage is 50.58%.

@@            Coverage Diff             @@
##           master    #2907      +/-   ##
==========================================
- Coverage    72.5%   72.47%   -0.04%     
==========================================
  Files         141      141              
  Lines       25744    25815      +71     
==========================================
+ Hits        18666    18709      +43     
- Misses       5998     6020      +22     
- Partials     1080     1086       +6

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Mar 18, 2020
@jackfrancis jackfrancis merged commit 65f7530 into Azure:master Mar 18, 2020
@acs-bot
Copy link

acs-bot commented Mar 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, jadarsie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jadarsie jadarsie deleted the addpool-vmas-fix branch May 4, 2020 18:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants