Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: add support for Kubernetes v1.16.15 and v1.18.15 on Azure Stack #4187

Merged
merged 4 commits into from
Jan 28, 2021

Conversation

JesusAlvarezTorres
Copy link
Contributor

@JesusAlvarezTorres JesusAlvarezTorres commented Jan 22, 2021

Reason for Change:

Adding support for Kubernetes v1.16.15 and v1.18.15 on Azure Stack

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@jackfrancis
Copy link
Member

code lgtm

to @jadarsie for final review/merge

jadarsie
jadarsie previously approved these changes Jan 25, 2021
@JesusAlvarezTorres JesusAlvarezTorres force-pushed the azs-k8s-1.16.15 branch 2 times, most recently from b7022b3 to 7fe8edd Compare January 27, 2021 22:10
@JesusAlvarezTorres JesusAlvarezTorres changed the title feat: add support for Kubernetes v1.16.15 on Azure Stack feat: add support for Kubernetes v1.16.15 and v1.18.15 on Azure Stack Jan 27, 2021
@jadarsie
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #4187 (fce573a) into master (5cca662) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4187      +/-   ##
==========================================
- Coverage   73.42%   73.36%   -0.06%     
==========================================
  Files         135      135              
  Lines       20849    20849              
==========================================
- Hits        15308    15296      -12     
- Misses       4566     4576      +10     
- Partials      975      977       +2     
Impacted Files Coverage Δ
pkg/api/common/versions.go 96.37% <ø> (ø)
pkg/api/vlabs/validate.go 80.65% <0.00%> (-1.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7455ccc...8436904. Read the comment docs.

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jackfrancis jackfrancis merged commit 69d94cc into Azure:master Jan 28, 2021
@acs-bot
Copy link

acs-bot commented Jan 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, JesusAlvarezTorres

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants