Added error parsing to OAuth signup form (#482)

Azure · Feb 14, 2020 · d1787b2 · d1787b2
1 parent 5e996b3
commit d1787b2
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/components/users/signup-social/ko/runtime/signup-social.ts b/src/components/users/signup-social/ko/runtime/signup-social.ts
@@ -12,6 +12,7 @@ import { UserPropertiesContract } from "../../../../../contracts/user";
 import { Utils } from "../../../../../utils";
 import { RouteHelper } from "../../../../../routing/routeHelper";
 import { IAuthenticator } from "./../../../../../authentication/IAuthenticator";
+import { MapiError } from "../../../../../services/mapiError";
 
 
 @RuntimeComponent({
@@ -65,7 +66,7 @@ export class SignupSocial {
         }
 
         const jwtToken = Utils.parseJwt(idToken);
-        
+
         this.firstName(jwtToken.given_name);
         this.lastName(jwtToken.family_name);
         this.email(jwtToken.email);
@@ -96,6 +97,10 @@ export class SignupSocial {
             body: JSON.stringify(user)
         });
 
+        if (!(response.statusCode >= 200 && response.statusCode <= 299)) {
+            throw MapiError.fromResponse(response);
+        }
+
         const sasTokenHeader = response.headers.find(x => x.name.toLowerCase() === "ocp-apim-sas-token");
 
         if (!sasTokenHeader) { // User not registered with APIM.

diff --git a/src/services/mapiError.ts b/src/services/mapiError.ts
@@ -1,3 +1,5 @@
+import { HttpResponse } from "@paperbits/common/http";
+
 export interface SmapiErrorDetails {
     target: string;
     message: string;
@@ -13,6 +15,15 @@ export class MapiError extends Error {
         Object.setPrototypeOf(this, MapiError.prototype);
     }
 
+    public static fromResponse(response: HttpResponse<any>): MapiError {
+        const responseObject = response.toObject();
+        const code = responseObject?.error?.code || "Error";
+        const message = responseObject?.error?.message || "Server error";
+        const details = responseObject?.error?.details || [];
+
+        return new MapiError(code, message, details);
+    }
+
     public toString(): string {
         return `${this.code}: ${this.message}`;
     }