Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong client name #1359

Closed
Tracked by #1356
Alancere opened this issue May 21, 2024 · 7 comments · Fixed by #1366
Closed
Tracked by #1356

Wrong client name #1359

Alancere opened this issue May 21, 2024 · 7 comments · Fixed by #1366
Assignees
Labels

Comments

@Alancere
Copy link
Member

Alancere commented May 21, 2024

tsp: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/communitytraining/Community.Management/main.tsp

image

@Alancere Alancere changed the title client name prefix Wrong client name May 21, 2024
@jhendrixMSFT
Copy link
Member

The names aren't wrong per se as they come from the hierarchical client specified in the tsp (the names aren't great though).

Can you please clarify what was the expectation?

@Alancere
Copy link
Member Author

The names aren't wrong per se as they come from the hierarchical client specified in the tsp (the names aren't great though).

Can you please clarify what was the expectation?

Expected to be consistent with the go sdk generated by autorest.go.
image

The operationId of spec swagger is as follows:
image

@jhendrixMSFT
Copy link
Member

jhendrixMSFT commented May 22, 2024

Thanks for clarifying.

Are we sure that the tsp is matching the OpenAPI? I suspect we're going to see this pattern a lot. So, before we go and modify the emitter, I'd like to confirm that the tsp matches the swagger.

@jhendrixMSFT
Copy link
Member

CC @tadelesh

@jhendrixMSFT
Copy link
Member

Hmm, maybe it's the case that since the emitter turns off hierarchical clients for ARM, we also turn off hierarchical client naming for ARM too (assuming the tsp is correct).

@tadelesh
Copy link
Member

is that name from {rootClientName}{subClientName}?

@jhendrixMSFT
Copy link
Member

Correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants