Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce mypy in the tests #82

Closed
lmazuel opened this issue Feb 15, 2019 · 1 comment
Closed

Introduce mypy in the tests #82

lmazuel opened this issue Feb 15, 2019 · 1 comment

Comments

@lmazuel
Copy link
Member

lmazuel commented Feb 15, 2019

This issue is about introducing mypy as part of the tox run, for both vanilla and azure. This means:

  • tox should install mypy as a dev dependency
  • tox should run mypy before doing the unittests

mypy should be run on both the generated code and the unittests (both Expected and AcceptanceTests folder)

Build should be clean with no errors. This might require update of annotations in msrest and msrestazure to solve some of them.
https://github.com/Azure/msrest-for-python/
https://github.com/Azure/msrestazure-for-python/

@lmazuel
Copy link
Member Author

lmazuel commented Jan 6, 2020

Fixed in #288

@lmazuel lmazuel closed this as completed Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant