Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cadl RLC] Can't get correct body type with wrapped body as parameter #1679

Closed
2 tasks
Tracked by #1654
MaryGao opened this issue Dec 1, 2022 · 0 comments · Fixed by #1690
Closed
2 tasks
Tracked by #1654

[Cadl RLC] Can't get correct body type with wrapped body as parameter #1679

MaryGao opened this issue Dec 1, 2022 · 0 comments · Fixed by #1690
Assignees
@qiaozha
Labels
DPG/RLC v2.0 GA Epic: Model Generation https://github.com/Azure/cadl-azure/issues/1944 RLC WS: Code Generation

Comments

@MaryGao
Copy link
Member

MaryGao commented Dec 1, 2022 •
edited
Loading

We have below Cadl definition:

https://github.com/Azure/azure-rest-api-specs-pr/blob/2d0503cc27e26d1c3e0c24bce53d539c5095f938/specification/adp/DataManagement/ingestion/discovery/operations.cadl#L12-L17

Currently the generated body was Discovery the correct body type would be DiscoveryCreationParameters.

  • transformBodyParameters should return correct body type
  • transformSchemas should generate DiscoveryCreationParameters model
@MaryGao MaryGao mentioned this issue Dec 1, 2022
Closed
8 tasks
@MaryGao MaryGao changed the title Issue from APIView comment: DiscoveryCreationParameters is missing [Cadl RLC] Can't get correct body type with wrapped body as parameter Dec 1, 2022
@MaryGao MaryGao added RLC DPG/RLC v2.0 GA Epic: Model Generation https://github.com/Azure/cadl-azure/issues/1944 WS: Code Generation labels Dec 1, 2022
@qiaozha qiaozha self-assigned this Dec 1, 2022
@qiaozha qiaozha mentioned this issue Dec 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qiaozha qiaozha

Labels
DPG/RLC v2.0 GA Epic: Model Generation https://github.com/Azure/cadl-azure/issues/1944 RLC WS: Code Generation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix custom wrapper issue in adp qiaozha/autorest.typescript
2 participants
@MaryGao @qiaozha