Feature: JupyterLab plugin #459
Conversation
paselem
commented
Mar 26, 2018
paselem
commented
- Include Jupyter Lab as a shipped plugin
- Add some more verbosity to logs
- Write a MASTER sentinel file to disk to know where master is
node_scripts/install/install.py
Outdated
| path = os.environ['PWD'] + '/MASTER' | ||
| print('Writing master file to: {}'.format(path)) | ||
| f = open(path, 'w') | ||
| f.write(master_node.ip_address) |
There was a problem hiding this comment.
This is already done here:
aztk/node_scripts/install/spark.py
Line 50 in c244e34
| @@ -0,0 +1,57 @@ | |||
| #!/bin/bash | |||
|
|
|||
| # This custom script only works on images where jupyter is pre-installed on the Docker image | |||
There was a problem hiding this comment.
We should change all of the plugins to be self-contained. Not sure that should be done in this PR, but we will have to change it soon anyways.
There was a problem hiding this comment.
Agreed, although this is no longer true since I'm install jupyter lab from conda. I copied the file over so that comment was unnecessary.
| } | ||
| EOF | ||
|
|
||
| # start jupyter notebook from /mnt - this is where we recommend you put your azure files mount point as well |
There was a problem hiding this comment.
does jupyterlab have the same restriction as jupyter where you can't navigate up the directory structure? Right now /mnt is cluttered with a lot of things, it would be nice to have jupyterlab's default directory point somewhere else.
There was a problem hiding this comment.
Same limitation - you cannot navigate 'up' from /mnt. Since this is where we place samples it seems like a reasonable place to put it - where else do you think it could work?
There was a problem hiding this comment.
No that's fine, /mnt/ is the best place since that is where their azure files will be mounted,
| class JupyterLabPlugin(PluginConfiguration): | ||
| def __init__(self): | ||
| super().__init__( | ||
| name="jupyter_lab", |
There was a problem hiding this comment.
Sorry to be super pedantic, but I think this might be better as jupyterlab since they brand it as one word. I think we should also make plugins case insensitive (not in this pr, just in general).
