This repository has been archived by the owner on Feb 3, 2021. It is now read-only.
Feature: Spark add output logs flag #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paselem
reviewed
Apr 3, 2018
| @@ -1,3 +1,4 @@ | |||
| import os | |||
paselem
reviewed
Apr 3, 2018
| spinner.start() | ||
| with open(os.path.abspath(os.path.expanduser(args.output)), "w", encoding="UTF-8") as f: | ||
| f.write(app_log.log) | ||
| spinner.stop() |
There was a problem hiding this comment.
Minor - probably want to wrap this in a try/catch block with the spinner.stop() in a finally statement in case writing to disk fails for any reason.
There was a problem hiding this comment.
Same comment in cluster submit below.
paselem
reviewed
Apr 3, 2018
| print(app_logs.log) | ||
| app_log = spark_client.get_job_application_log(args.job_id, args.app_name) | ||
| if args.output: | ||
| spinner = utils.Spinner() |
There was a problem hiding this comment.
Lines 26 through 30 seem to be used in several places. Worth moving to utils and re-using?
paselem
suggested changes
Apr 3, 2018
paselem
approved these changes
Apr 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #322