Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Federated identity credentials Azure CLI commands #20582

Closed
kjyam98 opened this issue Dec 2, 2021 · 6 comments · Fixed by #22727
Closed

Federated identity credentials Azure CLI commands #20582

kjyam98 opened this issue Dec 2, 2021 · 6 comments · Fixed by #22727
Assignees
Labels

Comments

@kjyam98
Copy link

kjyam98 commented Dec 2, 2021

Resource Provider
Azure Identity team

Description of Feature or Work Requested
Update/creation of Azure CLI commands to support the Federated identity credentials feature (https://docs.microsoft.com/en-us/azure/active-directory/develop/workload-identity-federation). Detailed spec here: https://microsoft.sharepoint.com/:w:/t/Identity-DevEx/Ecdj6sRt6uNOg_o4uxLZHW8BSkZxPxgdGLL0Sg8_Q6VtXQ?e=ICyONF

Minimum API Version Required
Currently the API is in beta but will GA early next year (Feb 2022 timeframe)

Swagger Link
Swagger file for Microsoft Graph API - OpenAPI description for applications module in staging beta (github.com).

The API paths of interest are:

  • /applications/{application-id}/federatedIdentityCredentials/*
  • /servicePrincipals/{servicePrincipal-id}/federatedIdentityCredentials/*

Target Date
Feb/Mar 2022 timeframe (to align with GA of the Federated identity credentials API)

@ghost ghost added the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Dec 2, 2021
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Dec 2, 2021
@yonzhan yonzhan added the Account az login/account label Dec 2, 2021
@yonzhan yonzhan modified the milestones: Jan 2022 (2022-02-01), Backlog Dec 2, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Dec 2, 2021

@jiasli for awareness

@yonzhan yonzhan modified the milestones: Backlog, Jan 2022 (2022-02-01) Dec 2, 2021
@jiasli
Copy link
Member

jiasli commented Dec 2, 2021

PowerShell? Perhaps it should be Azure CLI. 😉

@kjyam98
Copy link
Author

kjyam98 commented Dec 3, 2021

Good catch Jiashuo - updated just now. :)

@jiasli jiasli changed the title Federated identity credentials PowerShell commands Federated identity credentials Azure CLI commands Dec 3, 2021
@jongio
Copy link
Member

jongio commented Feb 8, 2022

@jiasli and @yonzhan

This is a complex configuration that I have researched and scripted extensively.

I have created a script here - that guides the user in setting this up and I expect the Azure CLI feature to do the same.

https://github.com/jongio/github-azure-oidc/blob/main/oidc.sh

  1. The CLI should allow the user to pass in a federatedIdentityCredential.json file or stream that allows them to create multiple FICs.

See the example here: https://github.com/jongio/github-azure-oidc/blob/main/fics.json

  1. The FIC creation call to the graph API has false positives. Meaning that the call to create the FIC returns as success, but in fact it is never created. So to ensure this API works correctly that bug needs to be fixed and in the meantime the Azure CLI should verify that the FICs are indeed created.

See example of the retry logic here: https://github.com/jongio/github-azure-oidc/blob/d733be7c811cb8fef110e0331a246fc5c654a231/oidc.sh#L97

(as of 2/8/22, I wasn't able to repro this issue, so we may be okay not checking for its existence. Most likely we just need a test to ensure it works)

You can learn more about OIDC with this video: https://youtu.be/r5QdsjjdRDs

Jon

@dstrockis
Copy link
Member

@yonzhan I am taking over from Kevin on this feature. Do I understand correctly that this work is scheduled for your April sprint, and we can expect it to complete by May 3?

I have some edits I'd like to make to the design of the proposed commands. Can you please sync up with me on that before starting implementation?

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 9, 2022

@dstrockis Good to know you are working on the design. You could send me an email about the design offline and this feature is already planned in Cu semester. My alias is yonzhan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants