-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed test failure in test_sql_db_mgmt. #2530
Conversation
The assertion error is: JMESPathCheckAssertionError: Query '[1].name' doesn't yield expected value 'master', instead the actual value is 'cliautomationdb01'. The fix is to sort the database names returned from the service so that it's guaranteed they are in order.
@jaredmoo, |
Codecov Report
@@ Coverage Diff @@
## master #2530 +/- ##
=======================================
Coverage 72.09% 72.09%
=======================================
Files 362 362
Lines 19758 19758
Branches 2909 2909
=======================================
Hits 14244 14244
Misses 4600 4600
Partials 914 914 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks, @jaredmoo |
* Azure/master: (478 commits) vm live test: allow more valid power states on vmss test verifications (Azure#2564) rbac:catch more graph error (Azure#2567) appservice: support to create plan when create a webapp (Azure#2550) Update storage tests (Azure#2556) Change PEP8 check filter from whitelist to blacklist (Azure#2557) Add scenario tests documentation (Azure#2555) [ACS] Adding support for configuring a default ACS cluster (Azure#2554) [ACS] Provide a short name alias for the orchestrator type flag (Azure#2553) Sql Import/Export CLI commands and test (Azure#2538) Fix format bug. (Azure#2549) [VM/VMSS] Improved disk caching support (Azure#2522) VM/VMSS: incorporate credentials validation logic used by portal (Azure#2537) Script that creates packaged releases package archive (Azure#2508) Adding alias for defaults flag (Azure#2540) Add wait commands and --no-wait support (Azure#2524) choice list outside of named arguments (Azure#2521) Fixed test failure in test_sql_db_mgmt. (Azure#2530) core: support login using service principal with a cert (Azure#2457) Add note about being in preview (Azure#2512) vm:fix distro check mechanism used by disk encryption (Azure#2511) ...
The assertion error is:
JMESPathCheckAssertionError: Query '[1].name' doesn't yield expected value 'master', instead the actual value is 'cliautomationdb01'.
The fix is to sort the database names returned from the service so that it's guaranteed they are in order.