Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Network] Fix network create format bug #2549

Merged
merged 1 commit into from
Mar 17, 2017
Merged

[Network] Fix network create format bug #2549

merged 1 commit into from
Mar 17, 2017

Conversation

tjprescott
Copy link
Member

Fixes #2542. The output transformer was swallowing errors, resulting in an output of {} instead of raising the error.

@tjprescott tjprescott added the Network az network vnet/lb/nic/dns/etc... label Mar 17, 2017
@tjprescott tjprescott added this to the Sprint 14 milestone Mar 17, 2017
@codecov-io
Copy link

codecov-io commented Mar 17, 2017

Codecov Report

Merging #2549 into master will increase coverage by 0.03%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master    #2549      +/-   ##
==========================================
+ Coverage    72.1%   72.13%   +0.03%     
==========================================
  Files         362      362              
  Lines       19791    19776      -15     
  Branches     2920     2920              
==========================================
- Hits        14270    14266       -4     
+ Misses       4604     4589      -15     
- Partials      917      921       +4
Impacted Files Coverage Δ
...twork/azure/cli/command_modules/network/_format.py 45% <80%> (+3.66%)
src/azure-cli-core/azure/cli/core/_util.py 66.66% <0%> (ø)
...dback/azure/cli/command_modules/feedback/custom.py 34.69% <0%> (ø)
...-cli-role/azure/cli/command_modules/role/custom.py 17.89% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9c09d2...11cb57e. Read the comment docs.

@tjprescott tjprescott merged commit 232beb7 into Azure:master Mar 17, 2017
@tjprescott tjprescott deleted the FixNetworkErrors branch March 17, 2017 22:36
thegalah pushed a commit to thegalah/azure-cli that referenced this pull request Mar 21, 2017
* Azure/master: (478 commits)
  vm live test: allow more valid power states on vmss test verifications (Azure#2564)
  rbac:catch more graph error (Azure#2567)
  appservice: support to create plan when create a webapp (Azure#2550)
  Update storage tests (Azure#2556)
  Change PEP8 check filter from whitelist to blacklist (Azure#2557)
  Add scenario tests documentation (Azure#2555)
  [ACS] Adding support for configuring a default ACS cluster (Azure#2554)
  [ACS] Provide a short name alias for the orchestrator type flag (Azure#2553)
  Sql Import/Export CLI commands and test (Azure#2538)
  Fix format bug. (Azure#2549)
  [VM/VMSS] Improved disk caching support (Azure#2522)
  VM/VMSS: incorporate credentials validation logic used by portal (Azure#2537)
  Script that creates packaged releases package archive (Azure#2508)
  Adding alias for defaults flag (Azure#2540)
  Add wait commands and --no-wait support (Azure#2524)
  choice list outside of named arguments (Azure#2521)
  Fixed test failure in test_sql_db_mgmt. (Azure#2530)
  core: support login using service principal with a cert (Azure#2457)
  Add note about being in preview (Azure#2512)
  vm:fix distro check mechanism used by disk encryption (Azure#2511)
  ...
@haroldrandom haroldrandom added cla-not-required Network az network vnet/lb/nic/dns/etc... labels Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-not-required Network az network vnet/lb/nic/dns/etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants