Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: E2E Framework [Scenarios] [5/6] #2527

Merged
merged 14 commits into from Jan 31, 2024
Merged

ci: E2E Framework [Scenarios] [5/6] #2527

merged 14 commits into from Jan 31, 2024

Conversation

matmerr
Copy link
Member

@matmerr matmerr commented Jan 18, 2024 •
edited

Reason for Change:

Has strong dependency on:

#2528
#2529

Issue Fixed:

Requirements:

Notes:

@matmerr matmerr changed the title ci: E2E Framework [scenarios] ci: E2E Framework [Scenarios] Jan 18, 2024
@matmerr matmerr marked this pull request as ready for review January 18, 2024 22:49
@matmerr matmerr requested a review from a team as a code owner January 18, 2024 22:49
@matmerr matmerr changed the title ci: E2E Framework [Scenarios] ci: E2E Framework [Scenarios] [5/6] Jan 18, 2024
@matmerr matmerr mentioned this pull request Jan 18, 2024
Merged
4 tasks
jpayne3506
jpayne3506 reviewed Jan 25, 2024
View reviewed changes
Copy link
Contributor

@jpayne3506 jpayne3506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a conversation offline about the E2E PR train global const(s) starting to run rampant. Once the train is complete there will be revisions to address.

test/e2e/scenarios/hubble/steps/validate-drop-metric.go Outdated Show resolved Hide resolved
test/e2e/scenarios/hubble/steps/validate-drop-metric.go Outdated Show resolved Hide resolved
@matmerr matmerr force-pushed the matmerr/e2eframework-scenarios branch 4 times, most recently from 8be23cb to 5ed96ec Compare January 26, 2024 02:26
This was referenced Jan 26, 2024
Closed
Closed
@matmerr matmerr force-pushed the matmerr/e2eframework-scenarios branch from 5ed96ec to ccf18dc Compare January 26, 2024 02:41
@matmerr matmerr force-pushed the matmerr/e2eframework-scenarios branch from ccf18dc to f492e63 Compare January 26, 2024 02:56
@matmerr matmerr force-pushed the matmerr/e2eframework-scenarios branch from 23496e8 to 943e0c7 Compare January 26, 2024 18:27
vakalapa
vakalapa previously approved these changes Jan 26, 2024
View reviewed changes
@matmerr matmerr added this pull request to the merge queue Jan 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 27, 2024
@vakalapa vakalapa added this pull request to the merge queue Jan 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 28, 2024
@matmerr matmerr added this pull request to the merge queue Jan 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 29, 2024
@matmerr matmerr added this pull request to the merge queue Jan 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 29, 2024
@matmerr matmerr force-pushed the matmerr/e2eframework-scenarios branch from c1abb22 to b44781e Compare January 29, 2024 18:57
@matmerr matmerr added this pull request to the merge queue Jan 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 30, 2024
@matmerr matmerr force-pushed the matmerr/e2eframework-scenarios branch from b0c5a8d to ac14788 Compare January 30, 2024 21:29
@matmerr matmerr added this pull request to the merge queue Jan 30, 2024
Merged via the queue into master with commit 5778117 Jan 31, 2024
15 checks passed
@matmerr matmerr deleted the matmerr/e2eframework-scenarios branch January 31, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpayne3506 jpayne3506 jpayne3506 left review comments

@vakalapa vakalapa vakalapa approved these changes

@thatmattlong thatmattlong Awaiting requested review from thatmattlong thatmattlong is a code owner automatically assigned from Azure/azure-sdn-members

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matmerr @vakalapa @jpayne3506