[Internal] Parser: Adds Antlr Dependancy #1691
Conversation
bchong95
requested review from
ealsur,
FabianMeiswinkel,
j82w,
kirankumarkolli,
kirillg and
sboshra
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Add|Fix|Refactor) Description"
Examples:
Diagnostics: Add GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fix null reference when using default(PartitionKey)
[v4] Client Encryption: Refactor code to external project
[Internal] Query: Add code generator for CosmosNumbers for easy additions in the future.
bchong95
changed the title
Microsoft.Azure.Cosmos/src/Query/Core/Parser/CstToAstVisitor.cs
Outdated
Show resolved
Hide resolved
| // This file isn't generated, but this comment is necessary to exclude it from StyleCop analysis. | ||
| // <auto-generated/> | ||
|
|
||
| /* Copyright (c) 2012-2017 The ANTLR Project. All rights reserved. |
There was a problem hiding this comment.
@kirankumarkolli is there clarification on requirements for the license?
There was a problem hiding this comment.
He literally said in the last meeting that he would work with the legal team about the licensing and that there is no need to block on it. I feel like we attend different meetings at this point. From now on I am requesting that all meetings are recorded for transparency.
There was a problem hiding this comment.
If this merged before legal is done then master is in a broken state and we can't do a release. Having master in a state where it can't be shipped is unacceptable, and worse is if someone does do a release it becomes a legal issue. The meeting recording is here. I might have missed it but the only agreement I found and remember was @kirankumarkolli agreeing to follow up with legal. I did not find anything saying this would be allowed to be merged without legal being done first.
There was a problem hiding this comment.
Let me clarify here.
- Work progress (working, PR, reviews etc...) don't need to get blocked on legal clearance (very high probability of clearance).
- PR merge do need clearance, so its a blocker.
- I am supposed to start the legal process last week and slipped it. Will do submit today.
j82w
changed the title
…e/azure-cosmos-dotnet-v3 into users/brchon/AntlrCopyPaste
|
Closing due to in-activity, pease feel free to re-open. |
Internal Parser: Merge Antlr Dependancy
Description
Copies over the Antlr runtime, but makes all the top level types internal and adds a auto generated tag, so that stylecop ignores these files. We can add other OSS dependencies here to avoid the nuget package dependency.