New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Internal] Parser: Adds Antlr Dependancy #1691
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
85629de
turned back on parser
bchong95 650ce48
adding ANTLR files
bchong95 c817c8a
got it to build
bchong95 6a48403
revert csproj
bchong95 585f640
revert
bchong95 c842970
revert
bchong95 a26c043
Merge branch 'master' into users/brchon/AntlrCopyPaste
sboshra 192083b
added Component Detection
bchong95 bc28813
Merge branch 'master' into users/brchon/AntlrCopyPaste
bchong95 2a652f6
adding notice file
bchong95 2df2767
Merge branch 'users/brchon/AntlrCopyPaste' of https://github.com/Azur…
bchong95 d19239a
added component name
bchong95 9e06212
updated cs proj
bchong95 ae23262
merged
bchong95 b4cfcc5
Merge branch 'master' into users/brchon/AntlrCopyPaste
bchong95 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
$a = Get-Content $args[0] | ||
$b = "// This file isn't generated, but this comment is necessary to exclude it from StyleCop analysis." | ||
$c = "// <auto-generated/>" | ||
$d = "" | ||
Set-Content $args[0] -value $b, $c, $d, $a |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,97 @@ | ||
// This file isn't generated, but this comment is necessary to exclude it from StyleCop analysis. | ||
// <auto-generated/> | ||
|
||
/* Copyright (c) 2012-2017 The ANTLR Project. All rights reserved. | ||
* Use of this file is governed by the BSD 3-clause license that | ||
* can be found in the LICENSE.txt file in the project root. | ||
*/ | ||
|
||
#if !PORTABLE | ||
|
||
using Antlr4.Runtime.Sharpen; | ||
using Encoding = System.Text.Encoding; | ||
using File = System.IO.File; | ||
|
||
namespace Antlr4.Runtime | ||
{ | ||
#if COMPACT | ||
using StreamReader = System.IO.StreamReader; | ||
#endif | ||
|
||
/// <summary> | ||
/// This is an | ||
/// <see cref="AntlrInputStream"/> | ||
/// that is loaded from a file all at once | ||
/// when you construct the object. | ||
/// </summary> | ||
internal class AntlrFileStream : AntlrInputStream | ||
{ | ||
protected internal string fileName; | ||
|
||
/// <exception cref="System.IO.IOException"/> | ||
public AntlrFileStream(string fileName) | ||
: this(fileName, null) | ||
{ | ||
} | ||
|
||
/// <exception cref="System.IO.IOException"/> | ||
public AntlrFileStream(string fileName, Encoding encoding) | ||
{ | ||
this.fileName = fileName; | ||
Load(fileName, encoding); | ||
} | ||
|
||
/// <exception cref="System.IO.IOException"/> | ||
public virtual void Load(string fileName, Encoding encoding) | ||
{ | ||
if (fileName == null) | ||
{ | ||
return; | ||
} | ||
|
||
string text; | ||
#if !COMPACT | ||
if (encoding != null) | ||
text = File.ReadAllText(fileName, encoding); | ||
else | ||
text = File.ReadAllText(fileName); | ||
#else | ||
if (encoding != null) | ||
text = ReadAllText(fileName, encoding); | ||
else | ||
text = ReadAllText(fileName); | ||
#endif | ||
|
||
data = text.ToCharArray(); | ||
n = data.Length; | ||
} | ||
|
||
public override string SourceName | ||
{ | ||
get | ||
{ | ||
return fileName; | ||
} | ||
} | ||
|
||
#if COMPACT | ||
private static string ReadAllText(string path) | ||
{ | ||
using (var reader = new StreamReader(path)) | ||
{ | ||
return reader.ReadToEnd(); | ||
} | ||
} | ||
|
||
private static string ReadAllText(string path, Encoding encoding) | ||
{ | ||
using (var reader = new StreamReader(path, encoding ?? Encoding.Default)) | ||
{ | ||
return reader.ReadToEnd(); | ||
} | ||
} | ||
#endif | ||
} | ||
} | ||
|
||
#endif |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kirankumarkolli is there clarification on requirements for the license?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
He literally said in the last meeting that he would work with the legal team about the licensing and that there is no need to block on it. I feel like we attend different meetings at this point. From now on I am requesting that all meetings are recorded for transparency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this merged before legal is done then master is in a broken state and we can't do a release. Having master in a state where it can't be shipped is unacceptable, and worse is if someone does do a release it becomes a legal issue. The meeting recording is here. I might have missed it but the only agreement I found and remember was @kirankumarkolli agreeing to follow up with legal. I did not find anything saying this would be allowed to be merged without legal being done first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me clarify here.