-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editorcofig: Adds editorcofig rules for all the VS defaults #1827
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors) Description"
Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO suggestions / warnings are useless. The main goal for me in having automation to enforce coding-style rules is to keep them out of PR and code-review discussions. It is a waste of everyone's time to discuss whether some method name should be preceeded with "this." or not. Letting the build process protect the rules means you keep consistency and avoid that waste of time in code reviews. With making this a suggestion you either don't end-up with consistent coding style anymore or you have the discussion back in the CRs. So I am pretty strongly against these half/baked suggestion/warning levels. Either we think a rule is important for readability - then enforce it - or it isn't important and then stop even bothering about it. I can live with both clear decisions - just dislike the middle-ground, because IMO it is the worst of both worlds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have any summary of which are the new rules introduced? Just in case some of the names are unfamiliar (I actually have no idea what some of them do).
42545c5
to
7ba45e4
Compare
Closing due to in-activity, pease feel free to re-open. |
Pull Request Template
Description
This is adding the editor config rules that are all set as part of the VS default to ensure that personal VS configurations don't mess with the defaults.
There will be a separate follow up PR to apply the rules to the project.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber